public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Einon <mark.einon@gmail.com>
To: ZHAO Gang <gamerh2o@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH v3 5/5] staging: et131x: update TODO list
Date: Thu, 21 Nov 2013 21:20:06 +0000	[thread overview]
Message-ID: <20131121212005.GF10691@einon.net> (raw)
In-Reply-To: <0ae40b21f7594be59bd90fd3e4c9002ba2f319c0.1384933520.git.gamerh2o@gmail.com>

On Wed, Nov 20, 2013 at 03:58:37PM +0800, ZHAO Gang wrote:
> remove items that have been done
> 
> Signed-off-by: ZHAO Gang <gamerh2o@gmail.com>

If the two small issues in patch 1/5 are fixed:

Acked-by: Mark Einon <mark.einon@gmail.com>

> ---
>  drivers/staging/et131x/README | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/staging/et131x/README b/drivers/staging/et131x/README
> index 8da96a6..00a34ea 100644
> --- a/drivers/staging/et131x/README
> +++ b/drivers/staging/et131x/README
> @@ -11,12 +11,7 @@ TODO:
>  	- Look at reducing the number of spinlocks
>  	- Simplify code in nic_rx_pkts(), when determining multicast_pkts_rcvd
>  	- Implement NAPI support
> -	- In et131x_tx(), don't return NETDEV_TX_BUSY, just drop the packet with kfree_skb().
>  	- Reduce the number of split lines by careful consideration of variable names etc.
> -	- Do this in et131x.c:
> -                struct fbr_lookup *fbr;
> -                fbr = rx_local->fbr[id];
> -	  Then replace all the instances of "rx_local->fbr[id]" with fbr.
>  
>  Please send patches to:
>  	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> -- 
> 1.8.3.1
> 

  reply	other threads:[~2013-11-21 21:20 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-20  7:53 [PATCH v3 0/5] staging: et131x: patches for et131x driver ZHAO Gang
2013-11-20  7:54 ` [PATCH v3 1/5] staging: et131x: clean up code ZHAO Gang
2013-11-21 21:18   ` Mark Einon
2013-11-20  7:55 ` [PATCH v3 2/5] staging: et131x: drop packet when error occurs in et131x_tx ZHAO Gang
2013-11-21 21:19   ` Mark Einon
2013-11-22  8:57     ` Dan Carpenter
2013-11-22  9:17     ` Denis Kirjanov
2013-11-22 11:47       ` ZHAO Gang
2013-11-22 11:56         ` Denis Kirjanov
2013-11-22 12:26           ` ZHAO Gang
2013-11-20  7:56 ` [PATCH v3 3/5] staging: et131x: stop read when hit max delay in et131x_phy_mii_read ZHAO Gang
2013-11-21 21:19   ` Mark Einon
2013-11-20  7:57 ` [PATCH v3 4/5] staging: et131x: remove spinlock adapter->lock ZHAO Gang
2013-11-21 21:19   ` Mark Einon
2013-11-20  7:58 ` [PATCH v3 5/5] staging: et131x: update TODO list ZHAO Gang
2013-11-21 21:20   ` Mark Einon [this message]
2013-11-21 21:18 ` [PATCH v3 0/5] staging: et131x: patches for et131x driver Mark Einon
2013-11-22  2:12   ` ZHAO Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131121212005.GF10691@einon.net \
    --to=mark.einon@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gamerh2o@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox