Re: [PATCH v3 5/5] staging: et131x: update TODO list

Mark Einon
2013-11-21T21:20:16Z

On Wed, Nov 20, 2013 at 03:58:37PM +0800, ZHAO Gang wrote:
> remove items that have been done
>
> Signed-off-by: ZHAO Gang <gamerh2o@gmail.com>

If the two small issues in patch 1/5 are fixed:

Acked-by: Mark Einon <mark.einon@gmail.com>

> ---
> drivers/staging/et131x/README | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/staging/et131x/README b/drivers/staging/et131x/README
> index 8da96a6..00a34ea 100644
> --- a/drivers/staging/et131x/README
> +++ b/drivers/staging/et131x/README
> @@ -11,12 +11,7 @@ TODO:
> - Look at reducing the number of spinlocks
> - Simplify code in nic_rx_pkts(), when determining multicast_pkts_rcvd
> - Implement NAPI support
> - - In et131x_tx(), don't return NETDEV_TX_BUSY, just drop the packet with kfree_skb().
> - Reduce the number of split lines by careful consideration of variable names etc.
> - - Do this in et131x.c:
> - struct fbr_lookup *fbr;
> - fbr = rx_local->fbr[id];
> - Then replace all the instances of "rx_local->fbr[id]" with fbr.
>
> Please send patches to:
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> --
> 1.8.3.1
>