Re: [PATCH 1/3] proc: change do_task_stat() to use while_each_thread()

Sameer Nanda
2013-11-22T20:16:19Z

On Fri, Nov 22, 2013 at 11:18 AM, Oleg Nesterov <oleg@redhat.com> wrote:
> do_task_stat() can use while_each_thread(), no changes in
> the compiled code.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Reviewed-by: Sameer Nanda <snanda@chromium.org>

> ---
> fs/proc/array.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/fs/proc/array.c b/fs/proc/array.c
> index c995807..c59e74f 100644
> --- a/fs/proc/array.c
> +++ b/fs/proc/array.c
> @@ -442,8 +442,7 @@ static int do_task_stat(struct seq_file *m, struct pid_namespace *ns,
> min_flt += t->min_flt;
> maj_flt += t->maj_flt;
> gtime += task_gtime(t);
> - t = next_thread(t);
> - } while (t != task);
> + } while_each_thread(task, t);
>
> min_flt += sig->min_flt;
> maj_flt += sig->maj_flt;
> --
> 1.5.5.1
>