public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "George Spelvin" <linux@horizon.com>
To: dhowells@redhat.com, torvalds@linux-foundation.org
Cc: linux@horizon.com, linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org
Subject: Re: [GIT] Security subsystem updates for 3.13
Date: 23 Nov 2013 01:05:27 -0500	[thread overview]
Message-ID: <20131123060527.15392.qmail@science.horizon.com> (raw)

On Thu, 21 Nov 2013, Linus Torvalds wrote:
> I do see *some* minimal comments on it from George Spelvin on lkml.

I'd like to apologize for dropping the ball on that.  I started working
on it seriously, but with various emergencies, I've been AFK from lkml
for the last month.

I'm not really thilled with it; I think the fanout of 16 is low for
something with its scale ambitions, and the properties expected of the
chunked key access method are not documented as clearly as they should be.

The way the key is fiddled the put keyring objects in a contiguous
range of the trie is a particularly egregious layering violation.

But I am convinced that it's been tested and works; my complaints are
in the areas of ugliness and efficiency.  And it's layered well enough that
it can be fixed later without radical sirgery.

             reply	other threads:[~2013-11-23  6:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-23  6:05 George Spelvin [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-11-07  0:51 [GIT] Security subsystem updates for 3.13 James Morris
2013-11-18 15:31 ` Josh Boyer
2013-11-18 23:30   ` James Morris
2013-11-18 23:54     ` Linus Torvalds
2013-11-19  5:38       ` James Morris
2013-11-19 14:46         ` David Howells
2013-11-19 12:20       ` James Morris
2013-11-22  4:22         ` Linus Torvalds
2013-11-22  9:36           ` James Morris
2013-11-22 14:01           ` Josh Boyer
2013-11-22 20:25           ` David Howells
2013-11-24  3:33             ` Linus Torvalds
2013-11-25  2:15               ` James Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131123060527.15392.qmail@science.horizon.com \
    --to=linux@horizon.com \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox