From: Borislav Petkov <bp@alien8.de>
To: Dave Young <dyoung@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
x86@kernel.org, mjg59@srcf.ucam.org, hpa@zytor.com,
James.Bottomley@HansenPartnership.com, vgoyal@redhat.com,
ebiederm@xmission.com, horms@verge.net.au,
kexec@lists.infradead.org, greg@kroah.com,
matt@console-pimps.org, toshi.kani@hp.com
Subject: Re: [patch 5/9 v3] efi: export more efi table variable to sysfs
Date: Sat, 23 Nov 2013 14:15:18 +0100 [thread overview]
Message-ID: <20131123131518.GC24148@pd.tnic> (raw)
In-Reply-To: <20131122024850.GC3874@dhcp-16-126.nay.redhat.com>
On Fri, Nov 22, 2013 at 10:48:50AM +0800, Dave Young wrote:
> > efi.config_table = (unsigned long)efi.systab->tables;
> > efi.fw_vendor = (unsigned long)efi.systab->fw_vendor;
> > efi.runtime = (unsigned long)efi.systab->runtime;
>
> Hmm, UEFI spec mentions the them like below so I use the order:
I'm sure by now you know you should not really trust the UEFI spec, or
any other spec for that matter :)
> Several fields of the EFI System Table must be converted from
> physical pointers to virtual pointers using the ConvertPointer()
> service. These fields include FirmwareVendor, RuntimeServices,
> and ConfigurationTable.
>
> But since you like the reverse I can change it in next version.
The reverse was simply a suggestion. The vertical alignment was more
what I aimed at because it makes this chunk much more readable IMO.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2013-11-23 13:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 6:17 [patch 0/9 v3] kexec kernel efi runtime support dyoung
2013-11-21 6:17 ` [patch 1/9 v3] efi: remove unused variables in __map_region dyoung
2013-11-21 15:54 ` Borislav Petkov
2013-11-21 6:17 ` [patch 2/9 v3] efi: add a wrapper function efi_map_region_fixed dyoung
2013-11-21 16:39 ` Borislav Petkov
2013-11-22 2:59 ` Dave Young
2013-11-21 6:17 ` [patch 3/9 v3] efi: reserve boot service fix dyoung
2013-11-21 6:17 ` [patch 4/9 v3] efi: cleanup efi_enter_virtual_mode function dyoung
2013-11-21 16:49 ` Borislav Petkov
2013-11-22 2:54 ` Dave Young
2013-11-21 6:17 ` [patch 5/9 v3] efi: export more efi table variable to sysfs dyoung
2013-11-21 16:42 ` Greg KH
2013-11-22 2:51 ` Dave Young
2013-11-21 16:57 ` Borislav Petkov
2013-11-22 2:48 ` Dave Young
2013-11-23 13:15 ` Borislav Petkov [this message]
2013-11-25 5:28 ` Dave Young
2013-11-21 6:17 ` [patch 6/9 v3] efi: export efi runtime memory mapping " dyoung
2013-11-21 6:17 ` [patch 7/9 v3] efi: passing kexec necessary efi data via setup_data dyoung
2013-11-21 6:17 ` [patch 8/9 v3] x86: add xloadflags bit for efi runtime support on kexec dyoung
2013-11-21 6:17 ` [patch 9/9 v3] x86: export x86 boot_params to sysfs dyoung
2013-11-21 16:45 ` Greg KH
2013-11-22 2:45 ` Dave Young
2013-11-21 6:52 ` [patch 0/9 v3] kexec kernel efi runtime support Dave Young
2013-11-22 22:29 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131123131518.GC24148@pd.tnic \
--to=bp@alien8.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=greg@kroah.com \
--cc=horms@verge.net.au \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=mjg59@srcf.ucam.org \
--cc=toshi.kani@hp.com \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox