From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: "ivan.khoronzhuk" <ivan.khoronzhuk@ti.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
wim@iguana.be, nsekhar@ti.com, linux-watchdog@vger.kernel.org,
devicetree@vger.kernel.org, mark.rutland@arm.com,
pawel.moll@arm.com, swarren@wwwdotorg.org,
ijc+devicetree@hellion.org.uk, galak@kernel.crashing.org,
rob.herring@calxeda.com, linux-kernel@vger.kernel.org,
grant.likely@linaro.org
Subject: Re: Fwd: [PATCH 7/8] watchdog: davinci: add "clocks" property
Date: Sat, 23 Nov 2013 18:57:46 +0100 [thread overview]
Message-ID: <201311231857.47104.arnd@arndb.de> (raw)
In-Reply-To: <527A28E8.4010204@ti.com>
On Wednesday 06 November 2013, ivan.khoronzhuk wrote:
> @@ -7,6 +7,10 @@ Required properties:
>
> - reg : Should contain WDT registers location and length
>
> +- clocks: phandle reference to the controller clock.
> + Required only for Keystone arch.
> + See clock-bindings.txt
> +
> Optional properties:
>
> - timeout-sec: Contains the watchdog timeout in seconds
I think it should really be listed under "Optional properties" and the
reference to Keystone removed. Note how the binding would need
to change otherwise if another platform started to use the clock, which
is a little silly.
Arnd
next prev parent reply other threads:[~2013-11-23 17:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1383680783-12114-8-git-send-email-ivan.khoronzhuk@ti.com>
2013-11-06 11:32 ` Fwd: [PATCH 7/8] watchdog: davinci: add "clocks" property ivan.khoronzhuk
2013-11-12 15:40 ` Santosh Shilimkar
2013-11-17 2:28 ` Guenter Roeck
2013-11-18 15:26 ` ivan.khoronzhuk
2013-11-23 17:57 ` Arnd Bergmann [this message]
2013-11-25 10:59 ` ivan.khoronzhuk
2013-11-25 12:15 ` Mark Rutland
2013-11-25 12:41 ` ivan.khoronzhuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201311231857.47104.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=galak@kernel.crashing.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=ivan.khoronzhuk@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nsekhar@ti.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=santosh.shilimkar@ti.com \
--cc=swarren@wwwdotorg.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox