From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756566Ab3KXEKW (ORCPT ); Sat, 23 Nov 2013 23:10:22 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:36946 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753669Ab3KXEKS (ORCPT ); Sat, 23 Nov 2013 23:10:18 -0500 Date: Sat, 23 Nov 2013 20:10:56 -0800 From: Greg Kroah-Hartman To: Santosh Shilimkar Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Marek Szyprowski Subject: Re: [PATCH] CMA: Fix the phys_addr_t print types Message-ID: <20131124041056.GA7415@kroah.com> References: <1385264221-29952-1-git-send-email-santosh.shilimkar@ti.com> <20131124034426.GB3873@kroah.com> <52917661.6050005@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52917661.6050005@ti.com> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 23, 2013 at 10:45:37PM -0500, Santosh Shilimkar wrote: > On Saturday 23 November 2013 10:44 PM, Greg Kroah-Hartman wrote: > > On Sat, Nov 23, 2013 at 10:37:01PM -0500, Santosh Shilimkar wrote: > >> @@ -250,8 +249,8 @@ int __init dma_contiguous_reserve_area(phys_addr_t size, phys_addr_t base, > >> *res_cma = cma; > >> cma_area_count++; > >> > >> - pr_info("CMA: reserved %ld MiB at %08lx\n", (unsigned long)size / SZ_1M, > >> - (unsigned long)base); > >> + pr_info("CMA: reserved %ld MiB at %pa\n", (unsigned long)size / SZ_1M, > >> + &base); > > > > Why is this pr_info() at all? That's just noise, please move it to > > pr_debug(). > > > Marek can comment better but I think its useful print to know CMA > reserved memory size. Useful to who?