Re: [PATCH 0024] asm-generic: Rename int-ll64.h to types.h

James Bottomley
2013-11-25T10:17:06Z

On Mon, 2013-11-25 at 09:55 +0100, Geert Uytterhoeven wrote:
> This patchset aims to rename <asm-generic/int-ll64.h> to
> <asm-generic/types.h> in kernelspace, as suggested by Arnd.
>
> While userspace still has both include/uapi/asm-generic/int-l64.h and
> include/uapi/asm-generic/int-ll64.h (int-l64.h may still be used on legacy
> 64-bit systems), kernelspace always uses "(unsigned) long long" for 64-bit
> integer values ("u64" and "s64"). Hence there's no longer a need to
> distinguish between int-l64 and int-ll64 in kernelspace, and int-ll64.h can
> just be called types.h

Is this a good idea? I thought some versions of gcc used long long for
128 bit integers, in which case int-ll64.h will give the wrong types for
u64 and s64. I think gcc is changing to use the __int128 type, so this
may be historical, but someone would need to validate that we have no
architectures with the old long long behaviour.

James