From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752118Ab3KYJV0 (ORCPT ); Mon, 25 Nov 2013 04:21:26 -0500 Received: from mga01.intel.com ([192.55.52.88]:56609 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750834Ab3KYJVZ (ORCPT ); Mon, 25 Nov 2013 04:21:25 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.93,766,1378882800"; d="scan'208";a="439167456" Date: Mon, 25 Nov 2013 11:28:02 +0200 From: Mika Westerberg To: Alexandre Courbot Cc: Alexandre Courbot , Linus Walleij , Stephen Warren , "linux-gpio@vger.kernel.org" , Linux Kernel Mailing List Subject: Re: [PATCH] gpiolib: add missing declarations Message-ID: <20131125092802.GQ2281@intel.com> References: <1385186069-28986-1-git-send-email-acourbot@nvidia.com> <20131125085831.GO2281@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 25, 2013 at 06:07:10PM +0900, Alexandre Courbot wrote: > On Mon, Nov 25, 2013 at 5:58 PM, Mika Westerberg > wrote: > > On Sat, Nov 23, 2013 at 02:54:29PM +0900, Alexandre Courbot wrote: > >> Add missing declarations and include files to avoid warnings during > >> compilation of include/gpio/driver.h. > > > > It would be good to have those warnings included in the changelog as well. > > As in, copy-pasting the compiler's output? Isn't the change explicit enough? If you just do 'git log' you can't see the change itself and that's where the changelog should help. If I see some warnings when I build the kernel, the first thing I usually do is to check 'git log' against linux-next and see if someone has already fixed that warning (grepping the warning message from changelog).