From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753801Ab3KYLLX (ORCPT ); Mon, 25 Nov 2013 06:11:23 -0500 Received: from top.free-electrons.com ([176.31.233.9]:44498 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753721Ab3KYLLW (ORCPT ); Mon, 25 Nov 2013 06:11:22 -0500 Date: Mon, 25 Nov 2013 08:11:27 -0300 From: Ezequiel Garcia To: Nicolas Pitre Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Russell King - ARM Linux , eric.y.miao@gmail.com, haojian.zhuang@gmail.com Subject: Re: [PATCH] ARM: pxa: Move iotable mapping inside vmalloc region Message-ID: <20131125111126.GB2408@localhost> References: <1385296571-23599-1-git-send-email-ezequiel.garcia@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 24, 2013 at 06:26:45PM -0500, Nicolas Pitre wrote: > On Sun, 24 Nov 2013, Ezequiel Garcia wrote: > > > In order to remove the following ugly message: > > > > BUG: mapping for 0x00000000 at 0xff000000 out of vmalloc space > > > > the iotable mappings should be re-located inside the vmalloc > > region. Such move was introduced at commit: > > > > commit 0536bdf33faff4d940ac094c77998cfac368cfff > > Author: Nicolas Pitre > > Date: Thu Aug 25 00:35:59 2011 -0400 > > > > ARM: move iotable mappings within the vmalloc region > > > > While at it, let's add some nicer defines to make the code > > more readable. > > > > Cc: Nicolas Pitre > > Signed-off-by: Ezequiel Garcia > > --- > > arch/arm/mach-pxa/generic.c | 12 +++++++++--- > > 1 file changed, 9 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm/mach-pxa/generic.c b/arch/arm/mach-pxa/generic.c > > index 4225417..7c01095 100644 > > --- a/arch/arm/mach-pxa/generic.c > > +++ b/arch/arm/mach-pxa/generic.c > > @@ -24,6 +24,7 @@ > > #include > > #include > > #include > > +#include > > > > #include > > #include > > @@ -77,6 +78,11 @@ EXPORT_SYMBOL(get_clk_frequency_khz); > > * Note: virtual 0xfffe0000-0xffffffff is reserved for the vector table > > * and cache flush area. > > */ > > + > > +#define UNCACHED_PHY 0x00000000 > > +#define UNCACHED_SIZE SZ_1M > > +#define UNCACHED_VIRT (VMALLOC_END - UNCACHED_SIZE) > > + > > static struct map_desc common_io_desc[] __initdata = { > > { /* Devs */ > > .virtual = 0xf2000000, > > @@ -84,9 +90,9 @@ static struct map_desc common_io_desc[] __initdata = { > > .length = 0x02000000, > > .type = MT_DEVICE > > }, { /* UNCACHED_PHYS_0 */ > > - .virtual = 0xff000000, > > - .pfn = __phys_to_pfn(0x00000000), > > - .length = 0x00100000, > > + .virtual = UNCACHED_VIRT, > > + .pfn = __phys_to_pfn(UNCACHED_PHY), > > + .length = UNCACHED_SIZE, > > .type = MT_DEVICE > > } > > }; > > You might wish to change the virtual address for this mapping, but > nowhere in your patch you are changing users of that virtual mapping. > Yeah, this patch is pure crap. I'll re-work it and submit a new (hopefully not stupid) version. Thanks for taking a look! -- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com