* [patch 01/12 v4] efi: remove unused variables in __map_region
@ 2013-11-25 8:56 dyoung
2013-11-25 9:19 ` Dave Young
0 siblings, 1 reply; 3+ messages in thread
From: dyoung @ 2013-11-25 8:56 UTC (permalink / raw)
To: linux-kernel
Cc: linux-efi, x86, mjg59, hpa, James.Bottomley, vgoyal, ebiederm,
horms, kexec, bp, greg, matt, toshi.kani, Dave Young,
Borislav Petkov
Hi,
References: <20131125085630.417850406@dhcp-16-126.nay.redhat.com>
Content-Disposition: inline; filename=01-remove-unused-var-in-map-region.patch
variables size and end is useless in this function, thus remove them.
Reported-by: Toshi Kani <toshi.kani@hp.com>
Signed-off-by: Dave Young <dyoung@redhat.com>
Acked-by: Borislav Petkov <bp@suse.de>
---
arch/x86/platform/efi/efi_64.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
--- efi.orig/arch/x86/platform/efi/efi_64.c
+++ efi/arch/x86/platform/efi/efi_64.c
@@ -148,15 +148,11 @@ void efi_setup_page_tables(void)
static void __init __map_region(efi_memory_desc_t *md, u64 va)
{
pgd_t *pgd = (pgd_t *)__va(real_mode_header->trampoline_pgd);
- unsigned long pf = 0, size;
- u64 end;
+ unsigned long pf = 0;
if (!(md->attribute & EFI_MEMORY_WB))
pf |= _PAGE_PCD;
- size = md->num_pages << PAGE_SHIFT;
- end = va + size;
-
if (kernel_map_pages_in_pgd(pgd, md->phys_addr, va, md->num_pages, pf))
pr_warn("Error mapping PA 0x%llx -> VA 0x%llx!\n",
md->phys_addr, va);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch 01/12 v4] efi: remove unused variables in __map_region
2013-11-25 8:56 [patch 01/12 v4] efi: remove unused variables in __map_region dyoung
@ 2013-11-25 9:19 ` Dave Young
2013-11-25 11:15 ` Borislav Petkov
0 siblings, 1 reply; 3+ messages in thread
From: Dave Young @ 2013-11-25 9:19 UTC (permalink / raw)
To: linux-kernel
Cc: linux-efi, x86, mjg59, hpa, James.Bottomley, vgoyal, ebiederm,
horms, kexec, bp, greg, matt, toshi.kani, Borislav Petkov
On 11/25/13 at 04:56pm, Dave Young wrote:
> Hi,
> References: <20131125085630.417850406@dhcp-16-126.nay.redhat.com>
> Content-Disposition: inline; filename=01-remove-unused-var-in-map-region.patch
Not sure why above references are added in content, another mistake.
please ignore them when you review the patches.
Sigh, looks like I should move to git-send-email for less error prone.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch 01/12 v4] efi: remove unused variables in __map_region
2013-11-25 9:19 ` Dave Young
@ 2013-11-25 11:15 ` Borislav Petkov
0 siblings, 0 replies; 3+ messages in thread
From: Borislav Petkov @ 2013-11-25 11:15 UTC (permalink / raw)
To: Dave Young
Cc: linux-kernel, linux-efi, x86, mjg59, hpa, James.Bottomley, vgoyal,
ebiederm, horms, kexec, greg, matt, toshi.kani, Borislav Petkov
On Mon, Nov 25, 2013 at 05:19:57PM +0800, Dave Young wrote:
> Sigh, looks like I should move to git-send-email for less error prone.
You won't regret it :-)
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-25 11:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-25 8:56 [patch 01/12 v4] efi: remove unused variables in __map_region dyoung
2013-11-25 9:19 ` Dave Young
2013-11-25 11:15 ` Borislav Petkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox