Re: [PATCH 0/4] thinkpad_acpi: Add support for controlling charge thresholds

[Julian Andres Klode <jak@jak-linux.org>]

On Mon, Nov 11, 2013 at 02:56:29PM +0100, Julian Andres Klode wrote:
> This patch series adds support for specifying charging thresholds,
> forcing a battery to discharge, and inhibiting charging, on ThinkPad
> Laptops using Sandy Bridge or newer processors.
> 
> The first two patches should be stable now, the third one does not work on
> my test system (but I'd appreciate if anyone with something other than an
> X230 tests it). 
> 
> The inhibit charging part is a bit unprecise, and I can obviously not test
> that -1 really means permanently, but I assume it does. I don't know whether
> this one should be merged.
> 
> Changes since the RFC PATCH:
>   - Define batteries more dynamically instead of statically using large
>     macros. Added support for up to 3 batteries, unsupported ones will not
>     be exported.
>   - Added 3 more new patches with more features
> 
> Julian Andres Klode (4):
>   thinkpad_acpi: Add support for controlling charge thresholds
>   thinkpad_acpi: battery: Add force_discharge attribute
>   thinkpad_acpi: battery: Add force_discharge_ac_break attribute
>   thinkpad_acpi: battery: Add inhibit_charge_minutes attribute
> 
>  Documentation/laptops/thinkpad-acpi.txt |  37 ++++
>  drivers/platform/x86/thinkpad_acpi.c    | 300 ++++++++++++++++++++++++++++++++
>  2 files changed, 337 insertions(+)
> 

I'd really like to get some comments on this series (especially by Henrique
and Matthew, they're responsible); so I know what I have to fix and whether
I should drop some of the later patches, and if the patch series has any
chance of being accepted...

-- 
Julian Andres Klode  - Debian Developer, Ubuntu Member

See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/.

Please do not top-post if possible.