public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: Jiri Slaby <jslaby@suse.cz>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] n_tty: Protect minimum_to_wake reset for concurrent readers
Date: Mon, 25 Nov 2013 08:36:02 -0800	[thread overview]
Message-ID: <20131125163602.GA19071@kroah.com> (raw)
In-Reply-To: <1383850917-24416-1-git-send-email-peter@hurleysoftware.com>

On Thu, Nov 07, 2013 at 02:01:57PM -0500, Peter Hurley wrote:
> With multiple, concurrent readers (each waiting to acquire the
> atomic_read_lock mutex), a departing reader may mistakenly reset
> minimum_to_wake after a new reader has already set a new value.
> 
> Protect the minimum_to_wake reset with the atomic_read_lock critical
> section.
> 
> Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
> ---
>  drivers/tty/n_tty.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

This patch doesn't apply to Linus's tree anymore (and hence, mine.)  Is
it needed for 3.13-final?  Or just 3.14-rc1?  Either way, can you
refresh it and resend?

thanks,

greg k-h

  reply	other threads:[~2013-11-25 16:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-07 19:01 [PATCH] n_tty: Protect minimum_to_wake reset for concurrent readers Peter Hurley
2013-11-25 16:36 ` Greg Kroah-Hartman [this message]
2013-11-25 17:12   ` Peter Hurley
2013-11-25 17:16     ` Greg Kroah-Hartman
2013-11-25 17:24       ` Greg Kroah-Hartman
2013-11-25 17:45         ` Peter Hurley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131125163602.GA19071@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=peter@hurleysoftware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox