From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Jiri Olsa <jolsa@redhat.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Namhyung Kim <namhyung@kernel.org>,
Mike Galbraith <efault@gmx.de>,
Stephane Eranian <eranian@google.com>,
David Ahern <dsahern@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH 1/3] perf tools: Add perf_data_file__write interface
Date: Mon, 25 Nov 2013 16:29:09 -0300 [thread overview]
Message-ID: <20131125192909.GA27323@ghostprotocols.net> (raw)
In-Reply-To: <1385130268-10664-2-git-send-email-jolsa@redhat.com>
Em Fri, Nov 22, 2013 at 03:24:26PM +0100, Jiri Olsa escreveu:
> }
> +
> +ssize_t perf_data_file__write(struct perf_data_file *file,
> + void *buf, size_t size)
> +{
> + ssize_t total = size;
> +
> + while (size) {
> + ssize_t ret = write(file->fd, buf, size);
> +
> + if (ret < 0) {
> + pr_err("failed to write perf data, error: %m\n");
> + return -1;
> + }
> +
> + size -= ret;
> + buf += ret;
> + }
> +
> + return total;
So this is the functional equivalent of "readn", so please move it to
just after "readn" and make this just a simple wrapper.
- Arnaldo
next prev parent reply other threads:[~2013-11-25 19:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 14:24 [PATCH 0/3] perf tools: Add data file write interface Jiri Olsa
2013-11-22 14:24 ` [PATCH 1/3] perf tools: Add perf_data_file__write interface Jiri Olsa
2013-11-25 19:29 ` Arnaldo Carvalho de Melo [this message]
2013-11-26 10:17 ` Jiri Olsa
2013-11-26 17:53 ` [PATCH] tools/perf/util: Document and clean up readn() a bit Ingo Molnar
2013-11-27 8:38 ` Adrian Hunter
2013-11-27 11:57 ` Ingo Molnar
2013-11-27 15:19 ` David Ahern
2013-11-27 15:50 ` Jiri Olsa
2013-11-27 15:54 ` Ingo Molnar
2013-11-22 14:24 ` [PATCH 2/3] perf record: Use perf_data_file__write for output file Jiri Olsa
2013-11-25 19:31 ` Arnaldo Carvalho de Melo
2013-11-26 10:16 ` Jiri Olsa
2013-11-22 14:24 ` [PATCH 3/3] perf inject: Handle output file via perf_data_file object Jiri Olsa
2013-11-25 19:40 ` Arnaldo Carvalho de Melo
2013-11-26 10:03 ` Jiri Olsa
2013-11-26 12:42 ` Arnaldo Carvalho de Melo
2013-11-26 13:07 ` Jiri Olsa
2013-11-22 15:01 ` [PATCH 0/3] perf tools: Add data file write interface David Ahern
2013-11-23 9:44 ` Jiri Olsa
2013-11-24 0:00 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131125192909.GA27323@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=adrian.hunter@intel.com \
--cc=dsahern@gmail.com \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox