Re: [PATCH] platform/chrome: Add pstore platform_device

[Felipe Balbi <balbi@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 948 bytes --]

Hi,

On Mon, Nov 25, 2013 at 11:59:50AM -0800, Olof Johansson wrote:
> >> +static int __init chromeos_pstore_init(void)
> >> +{
> >> +     if (dmi_check_system(chromeos_pstore_dmi_table))
> >
> > is this check really necessary ? I would assume that your probe would
> > only be called if the device matches the dmi MODULE_DEVICE_TABLE().
> >
> > Except that you don't have a probe function which is quite odd. Also,
> > there's nothing using chromeos_ramoops_data, how does this work ?
> 
> This is just a module that registers the device. The driver side is
> handled by pstore. See Documentation/ramoops.txt.
> 
> That's also why the DMI table is needed: The module init is generic,
> and if built-in instead of loaded based on DMI table contents, it will
> always run. There's no specific device to bind against, since there's
> none in the tables passed in from firmware in this case.

I see now, thanks :-)

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]