public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Jason Baron <jbaron@akamai.com>
Cc: benh@kernel.crashing.org, paulus@samba.org, ralf@linux-mips.org,
	akpm@linux-foundation.org, mpe@ellerman.id.au,
	felipe.contreras@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3 v3] build in panic_timeout value
Date: Tue, 26 Nov 2013 12:17:06 +0100	[thread overview]
Message-ID: <20131126111706.GA2410@gmail.com> (raw)
In-Reply-To: <cover.1385418410.git.jbaron@akamai.com>


* Jason Baron <jbaron@akamai.com> wrote:

> Hi,
> 
> I've now separated out the arch bits into separate patches. 
> Hopefully, it makes review easier. I also didn't address moving the 
> 'panic_timeout' command-line parameter up as an 'early_param()'. I 
> think it might make sense to move it up, especially for distro 
> kernels, but its not a need here, so I didn't want to just shove it 
> in. If needed, I think it can come in separately, as it shoudn't 
> affect this series.

The series looks good to me, I've applied the patches to 
tip:core/debug.

If Felipe Contreras's fix patch looks good to you then it would also 
be nice if you could send me that as well, on top of your patches.

That fix patch had only one remaining bug/problem, last I checked: if 
panic_timeout is turned into an early_param() then pause_on_oops 
should obviously also be turned into an early param. Changing just one 
of these parameters would be inconsistent and would lead to assymetric 
behavior in the early-crash case.

Thanks,

	Ingo

  parent reply	other threads:[~2013-11-26 11:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-25 23:23 [PATCH 0/3 v3] build in panic_timeout value Jason Baron
2013-11-25 23:23 ` [PATCH 1/3 v3] panic: Make panic_timeout configurable Jason Baron
2013-11-26 14:21   ` [tip:core/debug] " tip-bot for Jason Baron
2013-11-25 23:23 ` [PATCH 2/3 v3] mips: remove panic_timeout settings Jason Baron
2013-11-26 14:21   ` [tip:core/debug] MIPS: Remove " tip-bot for Ralf Baechle
2013-11-25 23:23 ` [PATCH 3/3 v3] powerpc: cleanup panic_timeout Jason Baron
2013-11-26 14:21   ` [tip:core/debug] powerpc: Clean up panic_timeout usage tip-bot for Jason Baron
2013-11-26 11:17 ` Ingo Molnar [this message]
2013-11-27  5:38   ` [PATCH 0/3 v3] build in panic_timeout value Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131126111706.GA2410@gmail.com \
    --to=mingo@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=felipe.contreras@gmail.com \
    --cc=jbaron@akamai.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox