From: NeilBrown <neilb@suse.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: fengguang.wu@intel.com, "Li, Shaohua" <shaohua.li@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: kernel BUG at drivers/md/raid5.c:693!
Date: Tue, 26 Nov 2013 15:31:06 +1100 [thread overview]
Message-ID: <20131126153106.6ae734c0@notabene.brown> (raw)
In-Reply-To: <20131125095323.GW10022@twins.programming.kicks-ass.net>
[-- Attachment #1: Type: text/plain, Size: 869 bytes --]
On Mon, 25 Nov 2013 10:53:23 +0100 Peter Zijlstra <peterz@infradead.org>
wrote:
> On Mon, Nov 25, 2013 at 10:35:22AM +1100, NeilBrown wrote:
> > Ingo/Peter: is it considered OK to call wake_up while holding a spinlock?
>
> Yes, very much so. Doing a wakeup isn't _that_ expensive.
Oh good. Thanks.
>
> > Could "sleeping spinlocks" affect this at all? (some sample stack traces are
> > below).
>
> Not entirely sure, are you referencing to -rt where me make spinlock_t
> pi-mutexes?
I'm not sure either. Just stabbing in the dark really.
The stack trace in the previous email seemed to suggest that a process was
blocking inside a wake_up call, but it wasn't at all conclusive. And I've
seen a few wake_ups in other stack traces which seem to be connected with
other deadlock. Probably some sort of co-incidence.
Thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2013-11-26 4:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-23 3:22 kernel BUG at drivers/md/raid5.c:693! fengguang.wu
2013-11-24 23:35 ` NeilBrown
2013-11-25 1:29 ` Fengguang Wu
2013-11-25 9:53 ` Peter Zijlstra
2013-11-26 4:31 ` NeilBrown [this message]
2013-11-26 9:42 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131126153106.6ae734c0@notabene.brown \
--to=neilb@suse.de \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox