From: Ingo Molnar <mingo@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: David Ahern <dsahern@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-kernel@vger.kernel.org,
Frederic Weisbecker <fweisbec@gmail.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 21/25] perf evsel: Skip ignored symbols while printing callchain
Date: Tue, 26 Nov 2013 17:18:52 +0100 [thread overview]
Message-ID: <20131126161852.GC7775@gmail.com> (raw)
In-Reply-To: <20131126143313.GD14838@ghostprotocols.net>
* Arnaldo Carvalho de Melo <acme@ghostprotocols.net> wrote:
> Em Tue, Nov 26, 2013 at 07:30:02AM -0700, David Ahern escreveu:
> > On 11/26/13, 7:20 AM, Arnaldo Carvalho de Melo wrote:
> > >Em Tue, Nov 26, 2013 at 12:52:21PM +0200, Adrian Hunter escreveu:
> > >>On 25/11/13 16:17, Arnaldo Carvalho de Melo wrote:
> > >>>From: David Ahern <dsahern@gmail.com>
> > >>> } else {
> > >>>+ if (al.sym->ignore)
>
> > >>Seems to segfault here because sym is null
>
> > >>>+ return;
>
> > >Changed it to look at (al.sym && al.sym->ignore), the rest of the code
> > >already checkfs if al.sym is NULL (printing [unknown], etc), can you
> > >please take a look at:
>
> > >https://git.kernel.org/cgit/linux/kernel/git/acme/linux.git/commit/?h=perf/core&id=c0dd57452349779e0e5d436db8f9448dfffcc512
>
> > >In an updated acme/perf/core branch?
>
> > Looks good to me. That's what I was going to send you. Sorry for the noise.
>
> No problem, I'll regenerate a +perf-core-for-mingo signed tag and
> send it with this new version with a [PATCH N/M v2] together with a
> new set of patches that I've put there today, not resending the
> unmodified patches from last pull req.
>
> Is that ok with you Ingo?
Sounds good to me!
Thanks,
Ingo
next prev parent reply other threads:[~2013-11-26 16:19 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 14:17 [GIT PULL 00/25] perf/core improvements and fixes Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 01/25] tools lib traceevent: Use helper trace-seq in print functions like kernel does Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 02/25] perf trace: Remove thread summary coloring Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 03/25] perf top: Make -g refer to callchains Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 04/25] perf completion: Introduce a layer of indirection Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 05/25] perf completion: Factor out compgen stuff Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 06/25] perf completion: Factor out call to __ltrim_colon_completions Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 07/25] perf completion: Introduce zsh support Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 08/25] perf completion: Rename file to reflect " Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 09/25] perf script: Move evname print code to process_event() Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 10/25] perf record: Make per-cpu mmaps the default Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 11/25] perf tools: Allow '--inherit' as the negation of '--no-inherit' Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 12/25] perf tools: Add option macro OPT_BOOLEAN_SET Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 13/25] perf record: Default -t option to no inheritance Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 14/25] perf timechart: Always try to print at least 15 tasks Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 15/25] perf timechart: Add option to limit number of tasks Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 16/25] perf timechart: Use proc_num to implement --power-only Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 17/25] perf timechart: Add support for displaying only tasks related data Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 18/25] perf timechart: Group figures and add title with details Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 19/25] perf timechart: Add support for -P and -T in timechart recording Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 20/25] perf timechart: Add backtrace support Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 21/25] perf evsel: Skip ignored symbols while printing callchain Arnaldo Carvalho de Melo
2013-11-26 10:52 ` Adrian Hunter
2013-11-26 14:20 ` Arnaldo Carvalho de Melo
2013-11-26 14:30 ` David Ahern
2013-11-26 14:33 ` Arnaldo Carvalho de Melo
2013-11-26 16:18 ` Ingo Molnar [this message]
2013-11-25 14:17 ` [PATCH 22/25] perf symbols: Move idle syms check from top to generic function Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 23/25] perf thread: Move comm_list check into function Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 24/25] perf tools: Export setup_list Arnaldo Carvalho de Melo
2013-11-25 14:17 ` [PATCH 25/25] perf script: Print callchains and symbols if they exist Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131126161852.GC7775@gmail.com \
--to=mingo@kernel.org \
--cc=acme@ghostprotocols.net \
--cc=adrian.hunter@intel.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox