From: Ingo Molnar <mingo@kernel.org>
To: Jean Pihet <jean.pihet@linaro.org>
Cc: linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org,
Will Deacon <will.deacon@arm.com>, Jiri Olsa <jolsa@redhat.com>,
Arnaldo <acme@ghostprotocols.net>,
patches@linaro.org
Subject: Re: [PATCH 1/2] perf: add per-feature check flags
Date: Tue, 26 Nov 2013 18:56:47 +0100 [thread overview]
Message-ID: <20131126175647.GA9958@gmail.com> (raw)
In-Reply-To: <1385045539-24537-2-git-send-email-jean.pihet@linaro.org>
* Jean Pihet <jean.pihet@linaro.org> wrote:
> Add CFLAGS and LDFLAGS for each feature to be checked. This allows
> to pass flags and parameters to the feature checks compilation.
> Also simplifies the feature check makefile, to come in a subsequent patch.
>
> Signed-off-by: Jean Pihet <jean.pihet@linaro.org>
> ---
> tools/perf/config/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> index f7d11a8..c551495 100644
> --- a/tools/perf/config/Makefile
> +++ b/tools/perf/config/Makefile
> @@ -102,7 +102,7 @@ endif
>
> feature_check = $(eval $(feature_check_code))
> define feature_check_code
> - feature-$(1) := $(shell $(MAKE) OUTPUT=$(OUTPUT_FEATURES) CFLAGS="$(EXTRA_CFLAGS)" LDFLAGS="$(LDFLAGS)" LIBUNWIND_LIBS="$(LIBUNWIND_LIBS)" -C config/feature-checks test-$1 >/dev/null 2>/dev/null && echo 1 || echo 0)
> + feature-$(1) := $(shell $(MAKE) OUTPUT=$(OUTPUT_FEATURES) CFLAGS="$(EXTRA_CFLAGS) $(FEATURE_CHECK_CFLAGS-$(1))" LDFLAGS="$(LDFLAGS) $(FEATURE_CHECK_LDFLAGS-$(1))" LIBUNWIND_LIBS="$(LIBUNWIND_LIBS)" -C config/feature-checks test-$1 >/dev/null 2>/dev/null && echo 1 || echo 0)
> endef
Acked-by: Ingo Molnar <mingo@kernel.org>
Thanks,
Ingo
next prev parent reply other threads:[~2013-11-26 17:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 14:52 [PATCH 0/2] perf: config: add per-feature check flags Jean Pihet
2013-11-21 14:52 ` [PATCH 1/2] perf: " Jean Pihet
2013-11-26 17:56 ` Ingo Molnar [this message]
2013-11-21 14:52 ` [PATCH 2/2] perf: unwinding: use the " Jean Pihet
2013-11-26 17:58 ` Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2013-12-03 16:09 [PATCH v2 0/2] perf: config: add " Jean Pihet
2013-12-03 16:09 ` [PATCH 1/2] perf: " Jean Pihet
2013-12-07 10:17 [PATCH v3 0/2] perf: config: " Jean Pihet
2013-12-07 10:17 ` [PATCH 1/2] perf: " Jean Pihet
2013-12-10 12:24 [PATCH v4 0/2] perf: config: " Jean Pihet
2013-12-10 12:24 ` [PATCH 1/2] perf: " Jean Pihet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131126175647.GA9958@gmail.com \
--to=mingo@kernel.org \
--cc=acme@ghostprotocols.net \
--cc=jean.pihet@linaro.org \
--cc=jolsa@redhat.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox