From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932320Ab3KZRKd (ORCPT ); Tue, 26 Nov 2013 12:10:33 -0500 Received: from mail-bk0-f53.google.com ([209.85.214.53]:55291 "EHLO mail-bk0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757336Ab3KZRKa (ORCPT ); Tue, 26 Nov 2013 12:10:30 -0500 From: Pali =?utf-8?q?Roh=C3=A1r?= To: Felipe Balbi , "Greg Kroah-Hartman" Subject: Re: BUG: usb: obex in g_nokia.ko causing kernel panic Date: Tue, 26 Nov 2013 18:10:22 +0100 User-Agent: KMail/1.13.7 (Linux/3.11.0-14-generic; KDE/4.11.3; x86_64; ; ) Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Pavel Machek , Aaro Koskinen , freemangordon@abv.bg, Sebastian Reichel References: <201311191151.17153@pali> In-Reply-To: <201311191151.17153@pali> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3110369.lOJQhOTTZU"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201311261810.22885@pali> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart3110369.lOJQhOTTZU Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Tuesday 19 November 2013 11:51:12 Pali Roh=C3=A1r wrote: > Hi! >=20 > For a long time (since 3.5 or 3.8? - I do not remember) obex > subdriver in g_nokia usb gadget module causing kernel panic > after module is loaded on Nokia N900. I do not know where is > problem and due to immediatelly kernel crash when loading > driver I was not able to see any dmesg output. Now I was able > to store something into mtd log and here is crash backtrace: >=20 > Log Entry 437 (at position 52) > <4>[ 18.606414] [] (__schedule+0x5c/0x50c) from > [] (schedule_timeout+0x1f4/0x25c) <4>[ 18.623809] > [] (schedule_timeout+0x1f4/0x25c) from [] > (wait_for_common+0xc8/0x1ac) <4>[ 18.649291] [] > (wait_for_common+0xc8/0x1ac) from [] > (omap_i2c_xfer+0x338/0x488) <4>[ 18.674499] [] > (omap_i2c_xfer+0x338/0x488) from [] > (__i2c_transfer+0x40/0x74) <4>[ 18.692047] [] > (__i2c_transfer+0x40/0x74) from [] > (i2c_transfer+0x6c/0x90) <4>[ 18.709320] [] > (i2c_transfer+0x6c/0x90) from [] > (regmap_i2c_read+0x48/0x68) <4>[ 18.726715] [] > (regmap_i2c_read+0x48/0x68) from [] > (_regmap_raw_read+0x128/0x220) <4>[ 18.752685] [] > (_regmap_raw_read+0x128/0x220) from [] > (regmap_raw_read+0xa0/0x130) <4>[ 18.779052] [] > (regmap_raw_read+0xa0/0x130) from [] > (regmap_bulk_read+0xf8/0x16c) <4>[ 18.805694] [] > (regmap_bulk_read+0xf8/0x16c) from [] > (twl_i2c_read+0xa4/0xe0) <4>[ 18.823730] [] > (twl_i2c_read+0xa4/0xe0) from [] > (__twl4030_phy_power.isra.12+0x1c/0x58) <4>[ 18.850921] > [] (__twl4030_phy_power.isra.12+0x1c/0x58) from > [] (twl4030_phy_power.part.14+0x80/0xc8) > <4>[ 18.879699] [] > (twl4030_phy_power.part.14+0x80/0xc8) from [] > (twl4030_set_suspend+0x54/0x1e8) > <4>[ 18.908325] [] > (twl4030_set_suspend+0x54/0x1e8) from [] > (omap2430_runtime_resume+0x5c/0x64) > <4>[ 18.937042] [] > (omap2430_runtime_resume+0x5c/0x64) from [] > (pm_generic_runtime_resume+0x2c/0x38) > <4>[ 18.966461] [] > (pm_generic_runtime_resume+0x2c/0x38) from [] > (__rpm_callback+0x54/0x80) <4>[ 18.995117] [] > (__rpm_callback+0x54/0x80) from [] > (rpm_callback+0x40/0x74) <4>[ 19.013610] [] > (rpm_callback+0x40/0x74) from [] > (rpm_resume+0x448/0x63c) <4>[ 19.031921] [] > (rpm_resume+0x448/0x63c) from [] > (rpm_resume+0x364/0x63c) <4>[ 19.050140] [] > (rpm_resume+0x364/0x63c) from [] > (__pm_runtime_resume+0x48/0x74) <4>[ 19.077728] > [] (__pm_runtime_resume+0x48/0x74) from > [] (musb_gadget_pullup+0x1c/0xb4) <4>[ 19.105895] > [] (musb_gadget_pullup+0x1c/0xb4) from [] > (usb_function_deactivate+0x54/0xa4 [libcomposite]) > <4>[ 19.135955] [] > (usb_function_deactivate+0x54/0xa4 [libcomposite]) from > [] (obex_bind+0x124/0x1d8 [usb_f_obex]) > <4>[ 19.166870] [] (obex_bind+0x124/0x1d8 > [usb_f_obex]) from [] (usb_add_function+0x58/0xf4 > [libcomposite]) > <4>[ 19.197143] [] (usb_add_function+0x58/0xf4 > [libcomposite]) from [] > (nokia_bind_config+0x204/0x250 [g_nokia]) > <4>[ 19.227905] [] (nokia_bind_config+0x204/0x250 > [g_nokia]) from [] (usb_add_config+0x28/0xc0 > [libcomposite]) > <4>[ 19.258483] [] (usb_add_config+0x28/0xc0 > [libcomposite]) from [] (nokia_bind+0x9c/0x21c > [g_nokia]) > <4>[ 19.288421] [] (nokia_bind+0x9c/0x21c > [g_nokia]) from [] (composite_bind+0x74/0x180 > [libcomposite]) > <4>[ 19.318420] [] (composite_bind+0x74/0x180 > [libcomposite]) from [] > (udc_bind_to_driver+0x2c/0xc4) > <4>[ 19.348114] [] (udc_bind_to_driver+0x2c/0xc4) > from [] (usb_gadget_probe_driver+0x74/0x94) <4>[ =20 > 19.377166] [] (usb_gadget_probe_driver+0x74/0x94) > from [] (do_one_initcall+0x94/0x138) <4>[ =20 > 19.406005] [] (do_one_initcall+0x94/0x138) from > [] (load_module+0x113c/0x13c4) <4>[ 19.434051] > [] (load_module+0x113c/0x13c4) from [] > (SyS_init_module+0xcc/0xec) <4>[ 19.462127] [] > (SyS_init_module+0xcc/0xec) from [] > (ret_fast_syscall+0x0/0x30) <0>[ 19.490753] Code: 0a00002e > e1a00004 eb001438 e598300c (e5d3202c) <4>[ 19.506805] ---[ > end trace 060b62ec0d68a78b ]--- <0>[ 19.523132] Kernel > panic - not syncing: Fatal exception in interrupt >=20 > (above dump is from 3.12-rc5 kernel) >=20 > When I disable obex code in drivers/usb/gadget/nokia.c then > gadget driver working fine without any crash, error or > warning. >=20 > Here is patch which disabling obex code which I using (for > 3.12): >=20 > diff --git a/drivers/usb/gadget/nokia.c > b/drivers/usb/gadget/nokia.c index ba47977..869cbfa 100644 > --- a/drivers/usb/gadget/nokia.c > +++ b/drivers/usb/gadget/nokia.c > @@ -110,10 +110,10 @@ static struct usb_function *f_acm_cfg1; > static struct usb_function *f_acm_cfg2; > static struct usb_function *f_ecm_cfg1; > static struct usb_function *f_ecm_cfg2; > -static struct usb_function *f_obex1_cfg1; > +/*static struct usb_function *f_obex1_cfg1; > static struct usb_function *f_obex2_cfg1; > static struct usb_function *f_obex1_cfg2; > -static struct usb_function *f_obex2_cfg2; > +static struct usb_function *f_obex2_cfg2;*/ > static struct usb_function *f_phonet_cfg1; > static struct usb_function *f_phonet_cfg2; >=20 > @@ -136,20 +136,20 @@ static struct usb_configuration > nokia_config_100ma_driver =3D { >=20 > static struct usb_function_instance *fi_acm; > static struct usb_function_instance *fi_ecm; > -static struct usb_function_instance *fi_obex1; > -static struct usb_function_instance *fi_obex2; > +/*static struct usb_function_instance *fi_obex1; > +static struct usb_function_instance *fi_obex2;*/ > static struct usb_function_instance *fi_phonet; >=20 > static int __init nokia_bind_config(struct usb_configuration > *c) { > struct usb_function *f_acm; > struct usb_function *f_phonet =3D NULL; > - struct usb_function *f_obex1 =3D NULL; > +/* struct usb_function *f_obex1 =3D NULL; */ > struct usb_function *f_ecm; > - struct usb_function *f_obex2 =3D NULL; > +/* struct usb_function *f_obex2 =3D NULL; */ > int status =3D 0; > - int obex1_stat =3D 0; > - int obex2_stat =3D 0; > +/* int obex1_stat =3D 0; > + int obex2_stat =3D 0;*/ > int phonet_stat =3D 0; >=20 > if (!IS_ERR(fi_phonet)) { > @@ -158,7 +158,7 @@ static int __init nokia_bind_config(struct > usb_configuration *c) pr_debug("could not get phonet > function\n"); > } >=20 > - if (!IS_ERR(fi_obex1)) { > +/* if (!IS_ERR(fi_obex1)) { > f_obex1 =3D usb_get_function(fi_obex1); > if (IS_ERR(f_obex1)) > pr_debug("could not get obex function 0\n"); > @@ -168,7 +168,7 @@ static int __init nokia_bind_config(struct > usb_configuration *c) f_obex2 =3D usb_get_function(fi_obex2); > if (IS_ERR(f_obex2)) > pr_debug("could not get obex function 1\n"); > - } > + }*/ >=20 > f_acm =3D usb_get_function(fi_acm); > if (IS_ERR(f_acm)) { > @@ -188,7 +188,7 @@ static int __init nokia_bind_config(struct > usb_configuration *c) pr_debug("could not add phonet > function\n"); > } >=20 > - if (!IS_ERR_OR_NULL(f_obex1)) { > +/* if (!IS_ERR_OR_NULL(f_obex1)) { > obex1_stat =3D usb_add_function(c, f_obex1); > if (obex1_stat) > pr_debug("could not add obex function 0\n"); > @@ -198,7 +198,7 @@ static int __init nokia_bind_config(struct > usb_configuration *c) obex2_stat =3D usb_add_function(c, > f_obex2); > if (obex2_stat) > pr_debug("could not add obex function 1\n"); > - } > + }*/ >=20 > status =3D usb_add_function(c, f_acm); > if (status) > @@ -213,14 +213,14 @@ static int __init > nokia_bind_config(struct usb_configuration *c) f_acm_cfg1 =3D > f_acm; > f_ecm_cfg1 =3D f_ecm; > f_phonet_cfg1 =3D f_phonet; > - f_obex1_cfg1 =3D f_obex1; > - f_obex2_cfg1 =3D f_obex2; > +/* f_obex1_cfg1 =3D f_obex1; > + f_obex2_cfg1 =3D f_obex2;*/ > } else { > f_acm_cfg2 =3D f_acm; > f_ecm_cfg2 =3D f_ecm; > f_phonet_cfg2 =3D f_phonet; > - f_obex1_cfg2 =3D f_obex1; > - f_obex2_cfg2 =3D f_obex2; > +/* f_obex1_cfg2 =3D f_obex1; > + f_obex2_cfg2 =3D f_obex2;*/ > } >=20 > status =3D fsg_bind_config(c->cdev, c, &fsg_common); > @@ -232,20 +232,20 @@ static int __init > nokia_bind_config(struct usb_configuration *c) err_ecm: > usb_remove_function(c, f_acm); > err_conf: > - if (!obex2_stat) > +/* if (!obex2_stat) > usb_remove_function(c, f_obex2); > if (!obex1_stat) > - usb_remove_function(c, f_obex1); > + usb_remove_function(c, f_obex1);*/ > if (!phonet_stat) > usb_remove_function(c, f_phonet); > usb_put_function(f_ecm); > err_get_ecm: > usb_put_function(f_acm); > err_get_acm: > - if (!IS_ERR_OR_NULL(f_obex2)) > +/* if (!IS_ERR_OR_NULL(f_obex2)) > usb_put_function(f_obex2); > if (!IS_ERR_OR_NULL(f_obex1)) > - usb_put_function(f_obex1); > + usb_put_function(f_obex1);*/ > if (!IS_ERR_OR_NULL(f_phonet)) > usb_put_function(f_phonet); > return status; > @@ -285,13 +285,13 @@ static int __init nokia_bind(struct > usb_composite_dev *cdev) if (IS_ERR(fi_phonet)) > pr_debug("could not find phonet function\n"); >=20 > - fi_obex1 =3D usb_get_function_instance("obex"); > +/* fi_obex1 =3D usb_get_function_instance("obex"); > if (IS_ERR(fi_obex1)) > pr_debug("could not find obex function 1\n"); >=20 > fi_obex2 =3D usb_get_function_instance("obex"); > if (IS_ERR(fi_obex2)) > - pr_debug("could not find obex function 2\n"); > + pr_debug("could not find obex function 2\n");*/ >=20 > fi_acm =3D usb_get_function_instance("acm"); > if (IS_ERR(fi_acm)) { > @@ -323,10 +323,10 @@ static int __init nokia_bind(struct > usb_composite_dev *cdev) >=20 > err_put_cfg1: > usb_put_function(f_acm_cfg1); > - if (!IS_ERR_OR_NULL(f_obex1_cfg1)) > +/* if (!IS_ERR_OR_NULL(f_obex1_cfg1)) > usb_put_function(f_obex1_cfg1); > if (!IS_ERR_OR_NULL(f_obex2_cfg1)) > - usb_put_function(f_obex2_cfg1); > + usb_put_function(f_obex2_cfg1);*/ > if (!IS_ERR_OR_NULL(f_phonet_cfg1)) > usb_put_function(f_phonet_cfg1); > usb_put_function(f_ecm_cfg1); > @@ -335,10 +335,10 @@ err_ecm_inst: > err_acm_inst: > usb_put_function_instance(fi_acm); > err_obex2_inst: > - if (!IS_ERR(fi_obex2)) > +/* if (!IS_ERR(fi_obex2)) > usb_put_function_instance(fi_obex2); > if (!IS_ERR(fi_obex1)) > - usb_put_function_instance(fi_obex1); > + usb_put_function_instance(fi_obex1);*/ > if (!IS_ERR(fi_phonet)) > usb_put_function_instance(fi_phonet); > err_usb: > @@ -349,14 +349,14 @@ err_fsg: >=20 > static int __exit nokia_unbind(struct usb_composite_dev > *cdev) { > - if (!IS_ERR_OR_NULL(f_obex1_cfg2)) > +/* if (!IS_ERR_OR_NULL(f_obex1_cfg2)) > usb_put_function(f_obex1_cfg2); > if (!IS_ERR_OR_NULL(f_obex2_cfg2)) > usb_put_function(f_obex2_cfg2); > if (!IS_ERR_OR_NULL(f_obex1_cfg1)) > usb_put_function(f_obex1_cfg1); > if (!IS_ERR_OR_NULL(f_obex2_cfg1)) > - usb_put_function(f_obex2_cfg1); > + usb_put_function(f_obex2_cfg1);*/ > if (!IS_ERR_OR_NULL(f_phonet_cfg1)) > usb_put_function(f_phonet_cfg1); > if (!IS_ERR_OR_NULL(f_phonet_cfg2)) > @@ -367,10 +367,10 @@ static int __exit nokia_unbind(struct > usb_composite_dev *cdev) usb_put_function(f_ecm_cfg2); >=20 > usb_put_function_instance(fi_ecm); > - if (!IS_ERR(fi_obex2)) > +/* if (!IS_ERR(fi_obex2)) > usb_put_function_instance(fi_obex2); > if (!IS_ERR(fi_obex1)) > - usb_put_function_instance(fi_obex1); > + usb_put_function_instance(fi_obex1);*/ > if (!IS_ERR(fi_phonet)) > usb_put_function_instance(fi_phonet); > usb_put_function_instance(fi_acm); >=20 > Please can you look where can be problem and why gadget > causing immediatelly kernel panic? >=20 > Note that g_nokia.ko usb gadget is for nokia n900 device. And > because it crashing (without above patch) I suggesting to > remove or comment obex code, because really driver is > unusable on that device... Hi! can you look at this problem? =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart3110369.lOJQhOTTZU Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlKU1f4ACgkQi/DJPQPkQ1JoVgCeJrQ2ydPpqA+WKxU6eFDi7vWq Qy0AmwaJaumnFv+6vPE6vlKG6hbwoB/8 =dYSs -----END PGP SIGNATURE----- --nextPart3110369.lOJQhOTTZU--