Re: [PATCH v3 05/15] KVM: MMU: update spte and add it into rmap before dirty log

Marcelo Tosatti
2013-11-15T00:23:07Z

On Wed, Oct 23, 2013 at 09:29:23PM +0800, Xiao Guangrong wrote:
> kvm_vm_ioctl_get_dirty_log() write-protects the spte based on the its dirty
> bitmap, so we should ensure the writable spte can be found in rmap before the
> dirty bitmap is visible. Otherwise, we clear the dirty bitmap but fail to
> write-protect the page which is detailed in the comments in this patch
>
> Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
> ---
> arch/x86/kvm/mmu.c | 84 ++++++++++++++++++++++++++++++++++++++++++------------
> arch/x86/kvm/x86.c | 10 +++++++
> 2 files changed, 76 insertions(+), 18 deletions(-)

Reviewed-by: Marcelo Tosatti <mtosatti@redhat.com>