From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752398Ab3K0JS4 (ORCPT ); Wed, 27 Nov 2013 04:18:56 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:55775 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751616Ab3K0JSw (ORCPT ); Wed, 27 Nov 2013 04:18:52 -0500 X-Originating-IP: 50.43.14.201 Date: Wed, 27 Nov 2013 01:18:41 -0800 From: Josh Triplett To: Chen Gang Cc: marek.belisko@gmail.com, kelleynnn@gmail.com, linux@rainbow-software.org, peter.p.waskiewicz.jr@intel.com, rkuo , "linux-kernel@vger.kernel.org" , "devel@driverdev.osuosl.org" , Greg KH Subject: Re: [PATCH] drivers: staging: ft1000: ft1000-usb: initialize 'status' with STATUS_SUCCESS in request_code_segment() Message-ID: <20131127091841.GA19465@leaf> References: <528AEFB7.4060301@gmail.com> <20131125011938.GB18921@codeaurora.org> <5292B845.3010404@gmail.com> <5292B8A0.7020409@gmail.com> <5294255E.7040105@gmail.com> <5295607E.2000504@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5295607E.2000504@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 27, 2013 at 11:01:18AM +0800, Chen Gang wrote: > If "!bool_case", it returns unexpected value instead of STATUS_SUCCESS, > so need fix it, the related warning (with allmodconfig under hexagon): > > CC [M] drivers/staging/ft1000/ft1000-usb/ft1000_download.o > drivers/staging/ft1000/ft1000-usb/ft1000_download.c: In function 'request_code_segment': > drivers/staging/ft1000/ft1000-usb/ft1000_download.c:581:6: warning: 'status' may be used uninitialized in this function [-Wuninitialized] > > > Signed-off-by: Chen Gang Reviewed-by: Josh Triplett > .../staging/ft1000/ft1000-usb/ft1000_download.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_download.c b/drivers/staging/ft1000/ft1000-usb/ft1000_download.c > index 68ded17..15f3062 100644 > --- a/drivers/staging/ft1000/ft1000-usb/ft1000_download.c > +++ b/drivers/staging/ft1000/ft1000-usb/ft1000_download.c > @@ -578,7 +578,7 @@ static int request_code_segment(struct ft1000_usb *ft1000dev, u16 **s_file, > u8 **c_file, const u8 *endpoint, bool boot_case) > { > long word_length; > - int status; > + int status = STATUS_SUCCESS; > > /*DEBUG("FT1000:REQUEST_CODE_SEGMENT\n");i*/ > word_length = get_request_value(ft1000dev); > -- > 1.7.7.6