From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753905Ab3K0LUc (ORCPT ); Wed, 27 Nov 2013 06:20:32 -0500 Received: from arkanian.console-pimps.org ([212.110.184.194]:52127 "EHLO arkanian.console-pimps.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752099Ab3K0LU3 (ORCPT ); Wed, 27 Nov 2013 06:20:29 -0500 Date: Wed, 27 Nov 2013 11:20:22 +0000 From: Matt Fleming To: Dave Young Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, x86@kernel.org, mjg59@srcf.ucam.org, hpa@zytor.com, James.Bottomley@HansenPartnership.com, vgoyal@redhat.com, ebiederm@xmission.com, horms@verge.net.au, kexec@lists.infradead.org, bp@alien8.de, greg@kroah.com, toshi.kani@hp.com Subject: Re: [PATCH v4 10/12] x86: export x86 boot_params to sysfs Message-ID: <20131127112022.GE18170@console-pimps.org> References: <1385445477-9665-1-git-send-email-dyoung@redhat.com> <1385445477-9665-11-git-send-email-dyoung@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1385445477-9665-11-git-send-email-dyoung@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Nov, at 01:57:55PM, Dave Young wrote: > +Users: > + Kexec Mailing List "Kexec" please. > +static ssize_t version_show(struct kobject *kobj, > + struct kobj_attribute *attr, char *buf) This is pretty strange indentation. Usually we prefer to line up the arguments like you've done elsewhere in this file. > +{ > + return sprintf(buf, "0x%04x\n", boot_params.hdr.version); > +} > + > +static struct kobj_attribute boot_params_version_attr = __ATTR_RO(version); > + > +static ssize_t boot_params_data_read(struct file *fp, struct kobject *kobj, > + struct bin_attribute *bin_attr, > + char *buf, loff_t off, size_t count) > +{ > + memcpy(buf, (void *)&boot_params + off, count); > + return count; > +} Don't we need some checks here to ensure we don't read past the end of boot_params? > +static ssize_t type_show(struct kobject *kobj, > + struct kobj_attribute *attr, char *buf) More whacky indentation. > +static int __init create_setup_data_node(struct kobject *parent, > + struct kobject **kobjp, int nr) Funky indentation. -- Matt Fleming, Intel Open Source Technology Center