Re: [PATCH v3 9/9] ARM: dts: add usb udc support to bcm281xx

Kishon Vijay Abraham I
2013-11-27T08:58:14Z

Hi,

On Monday 25 November 2013 11:46 PM, Matt Porter wrote:
> Adds USB OTG/PHY and clock support to BCM281xx and enables
> UDC support on the bcm11351-brt and bcm28155-ap boards.
>
> Signed-off-by: Matt Porter <matt.porter@linaro.org>
> Reviewed-by: Markus Mayer <markus.mayer@linaro.org>
> Reviewed-by: Tim Kryger <tim.kryger@linaro.org>
> ---
> arch/arm/boot/dts/bcm11351-brt.dts | 6 ++++++
> arch/arm/boot/dts/bcm11351.dtsi | 18 ++++++++++++++++++
> arch/arm/boot/dts/bcm28155-ap.dts | 8 ++++++++
> 3 files changed, 32 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm11351-brt.dts b/arch/arm/boot/dts/bcm11351-brt.dts
> index 23cd16d..396b704 100644
> --- a/arch/arm/boot/dts/bcm11351-brt.dts
> +++ b/arch/arm/boot/dts/bcm11351-brt.dts
> @@ -44,5 +44,11 @@
> status = "okay";
> };
>
> + usbotg: usb@3f120000 {
> + status = "okay";
> + };

using &usbotg could have been better. I mean if you have something like
&usbotg, you realise that the node has been created somewhere and we are just
referencing it here to add more properties.

Thanks
Kishon