Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, Nov 06, 2013 at 01:45:38PM +0100, Frank Haverkamp wrote:
> +/*
> + * Flags for extended output (dbg_print)
> + *   We define different levels of debugging for the appropriate unit.
> + */
> +#define dbg_card			0x00000001
> +#define dbg_card_ddcb			0x00000004
> +#define dbg_card_regs			0x00000008
> +#define dbg_card_sglist			0x00000400
> +#define dbg_card_pinning		0x00000800
> +
> +#define genwqe_dprintk(_cd, dbg_unit, fmt, ...) do {			\
> +		struct genwqe_dev *__cd = (_cd);			\
> +		if ((_cd)->debug & (dbg_unit))				\
> +			dev_info(&__cd->pci_dev->dev, fmt,		\
> +				 ## __VA_ARGS__);			\
> +	} while (0)

Ugh, really?  How is a debugging printk being sent out with dev_info()?

And why not just use dynamic kernel debugging and not create your own
masks and macros?  We are trying to make everything use the same
infrastructure, please don't create new ones for every individual driver
in the kernel, that's a mess.

thanks,

greg k-h