From: Mike Turquette <mturquette@linaro.org>
To: Boris BREZILLON <b.brezillon@overkiz.com>,
"Rob Herring" <rob.herring@calxeda.com>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Stephen Warren" <swarren@wwwdotorg.org>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Rob Landley" <rob@landley.net>,
"Andrew Victor" <linux@maxim.org.za>,
"Nicolas Ferre" <nicolas.ferre@atmel.com>,
"Jean-Christophe Plagniol-Villard" <plagnioj@jcrosoft.com>,
"Russell King" <linux@arm.linux.org.uk>,
"Felipe Balbi" <balbi@ti.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Grant Likely" <grant.likely@linaro.org>,
"Ludovic Desroches" <ludovic.desroches@atmel.com>,
"Josh Wu" <josh.wu@atmel.com>,
"Richard Genoud" <richard.genoud@gmail.com>
Cc: "Boris BREZILLON" <b.brezillon@overkiz.com>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v5 06/17] clk: at91: add PMC pll clocks
Date: Wed, 27 Nov 2013 13:48:43 -0800 [thread overview]
Message-ID: <20131127214843.16819.59481@quantum> (raw)
In-Reply-To: <1384293439-4525-1-git-send-email-b.brezillon@overkiz.com>
Quoting Boris BREZILLON (2013-11-12 13:57:19)
> +static const struct clk_ops pll_ops = {
> + .prepare = clk_pll_prepare,
> + .is_prepared = clk_pll_is_ready,
> + .disable = clk_pll_disable,
> + .is_enabled = clk_pll_is_ready,
> + .recalc_rate = clk_pll_recalc_rate,
> + .round_rate = clk_pll_round_rate,
> + .set_rate = clk_pll_set_rate,
> +};
Hi Boris,
It is a bit strange to see only a .prepare and .disable callback
populated. What happens if a driver calls clk_disable and then
clk_enable? You clock will still be disabled in hardware.
Regards,
Mike
next prev parent reply other threads:[~2013-11-27 21:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 20:51 [PATCH v5 00/17] ARM: at91: move to common clk framework Boris BREZILLON
2013-11-12 20:55 ` [PATCH v5 01/17] ARM: at91: move at91_pmc.h to include/linux/clk/at91_pmc.h Boris BREZILLON
2013-11-12 20:57 ` [PATCH v5 02/17] ARM: at91: add Kconfig options for common clk support Boris BREZILLON
2013-11-12 21:02 ` [PATCH v5 03/17] clk: at91: add PMC base support Boris BREZILLON
2013-11-12 21:04 ` [PATCH v5 04/17] clk: at91: add PMC macro file for dt definitions Boris BREZILLON
2013-11-12 21:54 ` [PATCH v5 05/17] clk: at91: add PMC main clock Boris BREZILLON
2013-11-12 21:57 ` [PATCH v5 06/17] clk: at91: add PMC pll clocks Boris BREZILLON
2013-11-27 21:48 ` Mike Turquette [this message]
2013-11-28 8:34 ` boris brezillon
2013-11-12 22:00 ` [PATCH v5 07/17] clk: at91: add PMC master clock Boris BREZILLON
2013-11-12 22:05 ` [PATCH v5 08/17] clk: at91: add PMC system clocks Boris BREZILLON
2013-11-27 22:05 ` Mike Turquette
2013-11-12 22:08 ` [PATCH v5 09/17] clk: at91: add PMC peripheral clocks Boris BREZILLON
2013-11-13 6:10 ` [PATCH v5 10/17] clk: at91: add peripheral clk macros for peripheral clk dt bindings Boris BREZILLON
2013-11-13 6:14 ` [PATCH v5 11/17] clk: at91: add PMC programmable clocks Boris BREZILLON
2013-11-13 6:17 ` [PATCH v5 12/17] clk: at91: add PMC utmi clock Boris BREZILLON
2013-11-13 6:20 ` [PATCH v5 13/17] clk: at91: add PMC usb clock Boris BREZILLON
2013-11-13 6:22 ` [PATCH v5 14/17] clk: at91: add PMC smd clock Boris BREZILLON
2013-11-13 7:12 ` [PATCH v5 15/17] dt: binding: add at91 clks dt bindings documentation Boris BREZILLON
2013-11-13 7:15 ` [PATCH v5 16/17] ARM: at91: move pit timer to common clk framework Boris BREZILLON
2013-11-13 7:18 ` [PATCH v5 17/17] ARM: at91: add new compatible strings for pmc driver Boris BREZILLON
2013-11-30 22:56 ` [PATCH v5 00/17] ARM: at91: move to common clk framework Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131127214843.16819.59481@quantum \
--to=mturquette@linaro.org \
--cc=b.brezillon@overkiz.com \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=josh.wu@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linux@maxim.org.za \
--cc=ludovic.desroches@atmel.com \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@atmel.com \
--cc=pawel.moll@arm.com \
--cc=plagnioj@jcrosoft.com \
--cc=richard.genoud@gmail.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox