From: Aurelien Jarno <aurelien@aurel32.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
"Theodore Ts'o" <tytso@mit.edu>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] UAPI linux/fs.h: add a warning about wrong ioctl argument types
Date: Thu, 28 Nov 2013 00:02:07 +0100 [thread overview]
Message-ID: <20131127230207.GF29912@hall.aurel32.net> (raw)
In-Reply-To: <20131127111340.GA24022@infradead.org>
On Wed, Nov 27, 2013 at 03:13:40AM -0800, Christoph Hellwig wrote:
> Thanks Aurelien,
>
> the added comment looks good and very useful,
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
Thanks for the review.
> We don't have any man pages documenting these ioctls or other user
> visible documentation, do we?
The only documentation I have found about these ioctls is from the
ioctl_list(2) manpage, but with different name and defined in
<linux/ext2_fs.h>. In any case they are correctly defined:
0x80046601 EXT2_IOC_GETFLAGS int *
0x40046602 EXT2_IOC_SETFLAGS const int *
0x80047601 EXT2_IOC_GETVERSION int *
0x40047602 EXT2_IOC_SETVERSION const int *
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
prev parent reply other threads:[~2013-11-27 23:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 10:40 [PATCH] UAPI linux/fs.h: add a warning about wrong ioctl argument types Aurelien Jarno
2013-11-27 11:13 ` Christoph Hellwig
2013-11-27 23:02 ` Aurelien Jarno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131127230207.GF29912@hall.aurel32.net \
--to=aurelien@aurel32.net \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox