From: Vinod Koul <vinod.koul@intel.com>
To: Olof Johansson <olof@lixom.net>
Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: pl08x: fix conversioin for generic unmap data
Date: Thu, 28 Nov 2013 11:30:43 +0530 [thread overview]
Message-ID: <20131128060043.GO8834@intel.com> (raw)
In-Reply-To: <1385528004-19423-1-git-send-email-olof@lixom.net>
On Tue, Nov 26, 2013 at 08:53:24PM -0800, Olof Johansson wrote:
> commit d38a8c622a1b ('dmaengine: prepare for generic 'unmap' data')
> added a generic unmap call but used the wrong argument for it. Fix it.
>
> Fixes: d38a8c622a1b ('dmaengine: prepare for generic 'unmap' data')
> Signed-off-by: Olof Johansson <olof@lixom.net>
Acked-by: Vinod Koul <vinod.koul@Intel.com>
> ---
>
> I can't actually tell what the intent of d38a8cc622a1b and how mappings
> are expected to be managed, but it's obviously passing the wrong thing
> in here so it seems like the appropriate fix.
>
> drivers/dma/amba-pl08x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
> index 16a2aa28f856..ec4ee5c1fe9d 100644
> --- a/drivers/dma/amba-pl08x.c
> +++ b/drivers/dma/amba-pl08x.c
> @@ -1169,7 +1169,7 @@ static void pl08x_desc_free(struct virt_dma_desc *vd)
> struct pl08x_txd *txd = to_pl08x_txd(&vd->tx);
> struct pl08x_dma_chan *plchan = to_pl08x_chan(vd->tx.chan);
>
> - dma_descriptor_unmap(txd);
> + dma_descriptor_unmap(&vd->tx);
> if (!txd->done)
> pl08x_release_mux(plchan);
>
> --
> 1.8.4.1.601.g02b3b1d
>
--
prev parent reply other threads:[~2013-11-28 6:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 4:53 [PATCH] dmaengine: pl08x: fix conversioin for generic unmap data Olof Johansson
2013-11-27 19:38 ` Dan Williams
2013-11-27 19:44 ` Olof Johansson
2013-11-27 19:49 ` Dan Williams
2013-11-27 19:55 ` Dan Williams
2013-11-28 6:00 ` Vinod Koul
2013-11-28 6:00 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131128060043.GO8834@intel.com \
--to=vinod.koul@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox