From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758630Ab3K1M4e (ORCPT ); Thu, 28 Nov 2013 07:56:34 -0500 Received: from merlin.infradead.org ([205.233.59.134]:49195 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755228Ab3K1M4c (ORCPT ); Thu, 28 Nov 2013 07:56:32 -0500 Date: Thu, 28 Nov 2013 09:56:19 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Ingo Molnar , linux-kernel@vger.kernel.org, Jean Pihet , Will Deacon , linaro-kernel@lists.linaro.org, patches@linaro.org Subject: Re: [PATCH 34/34] perf tools unwinding: Use the per-feature check flags Message-ID: <20131128125619.GA12292@ghostprotocols.net> References: <1385583394-3703-1-git-send-email-acme@infradead.org> <1385583394-3703-35-git-send-email-acme@infradead.org> <20131127224323.GB1350@krava.redhat.com> <20131128095801.GA1245@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131128095801.GA1245@krava.brq.redhat.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by merlin.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Nov 28, 2013 at 10:58:01AM +0100, Jiri Olsa escreveu: > On Wed, Nov 27, 2013 at 11:43:23PM +0100, Jiri Olsa wrote: > > On Wed, Nov 27, 2013 at 05:16:34PM -0300, Arnaldo Carvalho de Melo wrote: > > LINK perf > > /bin/ld: cannot find -lunwind > > /bin/ld: cannot find -lunwind-x86_64 > > collect2: error: ld returned 1 exit status > > make[1]: *** [perf] Error 1 > > make[1]: *** Waiting for unfinished jobs.... > > make: *** [all] Error 2 > > I haven't checked this one.. will do tomorrow > we need to plug libunwind flags/libs only if > the $(feature-libunwind) is enabled.. > NO_LIBUNWIND - user's decision not to link with libunwind or > architecture that does not support it > $(feature-libunwind) - if it's actually installed > attached change fixies that for me, feel free to use/merge it Argh, I used tests/make on one machine where those two patches by Jean were not applied, then rebased on another, the one I use to submit, those got included but not tests/make tested, which probably explains why this got thru :-\ Jean, can you please check that this works for you on ARM too? - Arnaldo