From: Lee Jones <lee.jones@linaro.org>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Samuel Ortiz <sameo@linux.intel.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Misael Lopez Cruz <misael.lopez@ti.com>
Subject: Re: [PATCH 3/5] MFD: twl6040: reg_defaults support for regmap
Date: Fri, 29 Nov 2013 16:00:32 +0000 [thread overview]
Message-ID: <20131129160032.GC26982@lee--X1> (raw)
In-Reply-To: <1385733827-19831-4-git-send-email-peter.ujfalusi@ti.com>
On Fri, 29 Nov 2013, Peter Ujfalusi wrote:
> Add reg_defaults to regmap and at the same time implement proper power state
> handling with using regcache_cache_only(), regcache_sync() and
> regcache_mark_dirty().
> This will make sure that we do not need to do restore operations in child
> drivers anymore.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> drivers/mfd/twl6040.c | 92 +++++++++++++++++++++++++++++++++++++++++++++++++--
> 1 file changed, 89 insertions(+), 3 deletions(-)
The code looks fine to me (me = !regmap expert), so with Mark's Ack I
will apply.
Mark, is an immutable branch required for this patch?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-11-29 16:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-29 14:03 [PATCH 0/5] ASoC/MFD: twl6040: Remove codec driver local reg cache Peter Ujfalusi
2013-11-29 14:03 ` [PATCH 1/5] ASoC: twl6040: Rename twl6040_is_path_unmuted -> twl6040_can_write_to_chip Peter Ujfalusi
2013-11-29 14:03 ` [PATCH 2/5] ASoC: twl6040: Custom caching for sensitive DL1/2 path registers Peter Ujfalusi
2013-11-29 14:03 ` [PATCH 3/5] MFD: twl6040: reg_defaults support for regmap Peter Ujfalusi
2013-11-29 16:00 ` Lee Jones [this message]
2013-11-29 16:04 ` Mark Brown
2013-12-18 18:56 ` Mark Brown
2013-12-19 9:06 ` Lee Jones
2013-12-19 10:52 ` Mark Brown
2013-12-19 17:20 ` Lee Jones
2013-12-19 18:31 ` Mark Brown
2013-11-29 14:03 ` [PATCH 4/5] ASoC: twl6040: Remove register restore functionality Peter Ujfalusi
2013-11-29 14:03 ` [PATCH 5/5] ASoC: twl6040: Remove self managed local reg_cache support Peter Ujfalusi
2013-11-29 14:49 ` [PATCH 0/5] ASoC/MFD: twl6040: Remove codec driver local reg cache Mark Brown
2013-12-19 18:37 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131129160032.GC26982@lee--X1 \
--to=lee.jones@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=misael.lopez@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox