From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932295Ab3K2QsX (ORCPT ); Fri, 29 Nov 2013 11:48:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46151 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757299Ab3K2QsT (ORCPT ); Fri, 29 Nov 2013 11:48:19 -0500 Date: Fri, 29 Nov 2013 17:49:04 +0100 From: Oleg Nesterov To: Tejun Heo Cc: Peter Zijlstra , zhang.yi20@zte.com.cn, lkml , Tetsuo Handa , Ingo Molnar Subject: Re: [PATCH 1/1] usermodehelper: kill ____call_usermodehelper()->set_cpus_allowed_ptr() Message-ID: <20131129164904.GA5124@redhat.com> References: <20131128121748.GN10022@twins.programming.kicks-ass.net> <20131128133152.GA821@redhat.com> <20131128133947.GR10022@twins.programming.kicks-ass.net> <20131128142359.GA6420@redhat.com> <20131128143155.GC3925@htj.dyndns.org> <20131128150055.GA11956@redhat.com> <20131128150233.GA10022@twins.programming.kicks-ass.net> <20131128193330.GA24767@redhat.com> <20131128193349.GB24767@redhat.com> <20131129134406.GA3717@htj.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131129134406.GA3717@htj.dyndns.org> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tejun, On 11/29, Tejun Heo wrote: > > Hey, Oleg. > > On Thu, Nov 28, 2013 at 08:33:49PM +0100, Oleg Nesterov wrote: > > @@ -208,13 +208,9 @@ static int ____call_usermodehelper(void *data) > > spin_lock_irq(¤t->sighand->siglock); > > flush_signal_handlers(current, 1); > > spin_unlock_irq(¤t->sighand->siglock); > > - > > - /* We can run anywhere, unlike our parent keventd(). */ > > - set_cpus_allowed_ptr(current, cpu_all_mask); > > I don't think this is correct on numa machines where unbound workers > are NUMA-node affine by default. Aaah, I see. And you even mentioned this before, but I didn't pay attention. Thank! Oleg.