[PATCH 1/2] Drivers: staging: dgap: checkpatch.pl cleanups

[PATCH 1/2] Drivers: staging: dgap: checkpatch.pl cleanups

[Aldo Iljazi]

A few checkpatch cleanups, particularly:

Lines 83, 87, 89, 196: Removed spaces before tabs.
Lines 141, 265.267: Removed trailing whitespace.

Signed-off-by: Aldo Iljazi <mail@aldo.io>
---
 drivers/staging/dgap/dgap_conf.h |   22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/staging/dgap/dgap_conf.h b/drivers/staging/dgap/dgap_conf.h
index 8809701..32ac17c 100644
--- a/drivers/staging/dgap/dgap_conf.h
+++ b/drivers/staging/dgap/dgap_conf.h
@@ -80,13 +80,13 @@
 #define MC8E8K  36
 
 #define AVANFS	42	/* start of Avanstar family definitions */
-#define A8P 	42
+#define A8P	42
 #define A16P	43
 #define AVANFE	43	/* end of Avanstar family definitions */
 
 #define DA2000FS	44	/* start of AccelePort 2000 family definitions */
-#define DA22 		44 /* AccelePort 2002 */
-#define DA24 		45 /* AccelePort 2004 */
+#define DA22		44 /* AccelePort 2002 */
+#define DA24		45 /* AccelePort 2004 */
 #define DA28		46 /* AccelePort 2008 */
 #define DA216		47 /* AccelePort 2016 */
 #define DAR4		48 /* AccelePort RAS 4 port */
@@ -138,11 +138,11 @@
 #define	CU	91
 #define	PRINT	92
 #define	XPRINT	93
-#define CMAJOR   94 
-#define ALTPIN  95
-#define STARTO 96
-#define USEINTR  97
-#define PCIINFO  98
+#define CMAJOR	94
+#define ALTPIN	95
+#define STARTO	96
+#define USEINTR	97
+#define PCIINFO	98
 
 #define	TTSIZ	100
 #define	CHSIZ	101
@@ -193,7 +193,7 @@ struct cnode {
 
 	union {
 		struct {
-			char  type;	/* Board Type 		*/
+			char  type;	/* Board Type		*/
 			short port;	/* I/O Address		*/
 			char  *portstr; /* I/O Address in string */
 			long  addr;	/* Memory Address	*/
@@ -262,9 +262,9 @@ struct cnode {
 		} module;
 
 		char *ttyname;
-		
+
 		char *cuname;
-		
+
 		char *printname;
 
 		int  majornumber;
-- 
1.7.9.5

[PATCH 2/2] Drivers: staging: dgap: checkpatch.pl cleanups

[Aldo Iljazi]

A few checkpatch cleanups, particularly:

Lines 26, 60: Removed trailing whitespace.
Lines 36-38, 42-44, 47: Removed spaces at the start of the lines.

Signed-off-by: Aldo Iljazi <mail@aldo.io>
---
 drivers/staging/dgap/dgap_downld.h |   22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/staging/dgap/dgap_downld.h b/drivers/staging/dgap/dgap_downld.h
index 271ac19..b471284 100644
--- a/drivers/staging/dgap/dgap_downld.h
+++ b/drivers/staging/dgap/dgap_downld.h
@@ -23,7 +23,7 @@
  */
 
 /*
-** downld.h 
+** downld.h
 **  - describes the interface between the user level download process
 **    and the concentrator download driver.
 */
@@ -33,18 +33,18 @@
 
 
 struct fepimg {
-    int type;				/* board type */
-    int	len;				/* length of image */
-    char fepimage[1];			/* beginning of image */
+	int type;				/* board type */
+	int	len;				/* length of image */
+	char fepimage[1];			/* beginning of image */
 };
 
 struct downldio {
-    unsigned int req_type;		/* FEP or concentrator */
-    unsigned int bdid;			/* opaque board identifier */
-    union {
-	struct downld_t dl;		/* download structure */
-	struct fepimg   fi;		/* fep/bios image structure */
-    } image;
+	unsigned int req_type;		/* FEP or concentrator */
+	unsigned int bdid;			/* opaque board identifier */
+	union {
+		struct downld_t dl;		/* download structure */
+		struct fepimg   fi;		/* fep/bios image structure */
+	} image;
 };
 
 #define DIGI_DLREQ_GET	(('d'<<8) | 220)
@@ -57,7 +57,7 @@ struct downldio {
 #define DIGI_NUKE_RESET_ALL	 (1 << 31)
 #define DIGI_NUKE_INHIBIT_POLLER (1 << 30)
 #define DIGI_NUKE_BRD_NUMB        0x0f
-	
+
 
 
 #define	DLREQ_BIOS	0
-- 
1.7.9.5

Re: [PATCH 2/2] Drivers: staging: dgap: checkpatch.pl cleanups

[Dan Carpenter]

On Sun, Dec 01, 2013 at 05:43:09PM +0200, Aldo Iljazi wrote:
>  #define DIGI_DLREQ_GET	(('d'<<8) | 220)
> @@ -57,7 +57,7 @@ struct downldio {
>  #define DIGI_NUKE_RESET_ALL	 (1 << 31)
>  #define DIGI_NUKE_INHIBIT_POLLER (1 << 30)
>  #define DIGI_NUKE_BRD_NUMB        0x0f
> -	
> +
>  
>  
>  #define	DLREQ_BIOS	0

We shouldn't have two blank lines in a row.

regards,
dan carpenter

Re: [PATCH 1/2] Drivers: staging: dgap: checkpatch.pl cleanups

[Dan Carpenter]

On Sun, Dec 01, 2013 at 05:43:08PM +0200, Aldo Iljazi wrote:
> A few checkpatch cleanups, particularly:
> 
> Lines 83, 87, 89, 196: Removed spaces before tabs.
> Lines 141, 265.267: Removed trailing whitespace.
> 

Don't send two patches with the exact same subject.

regards,
dan carpenter