[PATCH v1 1/2] lib/scatterlist: export sg_miter_skip()

[PATCH v1 1/2] lib/scatterlist: export sg_miter_skip()

[Ming Lei]

sg_copy_buffer() can't meet demand for some drrivers(such usb
mass storage), so we have to use the sg_miter_* APIs to access
sg buffer, then need export sg_miter_skip() for these drivers.

The API is needed for converting to sg_miter_* APIs in USB storage
driver for accessing sg buffer.

Acked-by: Andrew Morton <akpm@linux-foundation.org>
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: Tejun Heo <tj@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Ming Lei <ming.lei@canonical.com>
---
 include/linux/scatterlist.h |    1 +
 lib/scatterlist.c           |    3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/include/linux/scatterlist.h b/include/linux/scatterlist.h
index adae88f..a964f72 100644
--- a/include/linux/scatterlist.h
+++ b/include/linux/scatterlist.h
@@ -345,6 +345,7 @@ struct sg_mapping_iter {
 
 void sg_miter_start(struct sg_mapping_iter *miter, struct scatterlist *sgl,
 		    unsigned int nents, unsigned int flags);
+bool sg_miter_skip(struct sg_mapping_iter *miter, off_t offset);
 bool sg_miter_next(struct sg_mapping_iter *miter);
 void sg_miter_stop(struct sg_mapping_iter *miter);
 
diff --git a/lib/scatterlist.c b/lib/scatterlist.c
index d16fa29..3a8e8e8 100644
--- a/lib/scatterlist.c
+++ b/lib/scatterlist.c
@@ -495,7 +495,7 @@ static bool sg_miter_get_next_page(struct sg_mapping_iter *miter)
  *   true if @miter contains the valid mapping.  false if end of sg
  *   list is reached.
  */
-static bool sg_miter_skip(struct sg_mapping_iter *miter, off_t offset)
+bool sg_miter_skip(struct sg_mapping_iter *miter, off_t offset)
 {
 	sg_miter_stop(miter);
 
@@ -513,6 +513,7 @@ static bool sg_miter_skip(struct sg_mapping_iter *miter, off_t offset)
 
 	return true;
 }
+EXPORT_SYMBOL(sg_miter_skip);
 
 /**
  * sg_miter_next - proceed mapping iterator to the next mapping
-- 
1.7.9.5

Re: [PATCH v1 1/2] lib/scatterlist: export sg_miter_skip()

[Tejun Heo]

On Tue, Nov 26, 2013 at 12:43:37PM +0800, Ming Lei wrote:
> sg_copy_buffer() can't meet demand for some drrivers(such usb
> mass storage), so we have to use the sg_miter_* APIs to access
> sg buffer, then need export sg_miter_skip() for these drivers.
> 
> The API is needed for converting to sg_miter_* APIs in USB storage
> driver for accessing sg buffer.
> 
> Acked-by: Andrew Morton <akpm@linux-foundation.org>
> Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Jens Axboe <axboe@kernel.dk>
> Signed-off-by: Ming Lei <ming.lei@canonical.com>

Reviewed-by: Tejun Heo <tj@kernel.org>

I suppose this should go through -mm?

Thanks.

-- 
tejun

Re: [PATCH v1 1/2] lib/scatterlist: export sg_miter_skip()

[Ming Lei]

On Sat, Nov 30, 2013 at 6:23 AM, Tejun Heo <tj@kernel.org> wrote:
> On Tue, Nov 26, 2013 at 12:43:37PM +0800, Ming Lei wrote:
>> sg_copy_buffer() can't meet demand for some drrivers(such usb
>> mass storage), so we have to use the sg_miter_* APIs to access
>> sg buffer, then need export sg_miter_skip() for these drivers.
>>
>> The API is needed for converting to sg_miter_* APIs in USB storage
>> driver for accessing sg buffer.
>>
>> Acked-by: Andrew Morton <akpm@linux-foundation.org>
>> Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
>> Cc: Tejun Heo <tj@kernel.org>
>> Cc: Jens Axboe <axboe@kernel.dk>
>> Signed-off-by: Ming Lei <ming.lei@canonical.com>
>
> Reviewed-by: Tejun Heo <tj@kernel.org>

Thanks.

> I suppose this should go through -mm?

Last round, Andrew said it can be though whatever tree, so
given dependency reason, it is better to merge via greg's tree.

Greg, could you merge these two patches via your usb-next tree?

Thanks,
--
Ming Lei

Re: [PATCH v1 1/2] lib/scatterlist: export sg_miter_skip()

[Greg Kroah-Hartman]

On Mon, Dec 02, 2013 at 10:11:21AM +0800, Ming Lei wrote:
> On Sat, Nov 30, 2013 at 6:23 AM, Tejun Heo <tj@kernel.org> wrote:
> > On Tue, Nov 26, 2013 at 12:43:37PM +0800, Ming Lei wrote:
> >> sg_copy_buffer() can't meet demand for some drrivers(such usb
> >> mass storage), so we have to use the sg_miter_* APIs to access
> >> sg buffer, then need export sg_miter_skip() for these drivers.
> >>
> >> The API is needed for converting to sg_miter_* APIs in USB storage
> >> driver for accessing sg buffer.
> >>
> >> Acked-by: Andrew Morton <akpm@linux-foundation.org>
> >> Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> >> Cc: Tejun Heo <tj@kernel.org>
> >> Cc: Jens Axboe <axboe@kernel.dk>
> >> Signed-off-by: Ming Lei <ming.lei@canonical.com>
> >
> > Reviewed-by: Tejun Heo <tj@kernel.org>
> 
> Thanks.
> 
> > I suppose this should go through -mm?
> 
> Last round, Andrew said it can be though whatever tree, so
> given dependency reason, it is better to merge via greg's tree.
> 
> Greg, could you merge these two patches via your usb-next tree?

Yes, will do.