From: Lee Jones <lee.jones@linaro.org>
To: Axel Lin <axel.lin@ingics.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Mark Brown <broonie@kernel.org>,
Balaji Rao <balajirrao@openmoko.org>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFT][PATCH] mfd: pcf50633: Correct device name for pcf50633 regulator
Date: Mon, 2 Dec 2013 10:59:18 +0000 [thread overview]
Message-ID: <20131202105918.GA31626@lee--X1> (raw)
In-Reply-To: <1385785263.24696.2.camel@phoenix>
On Sat, 30 Nov 2013, Axel Lin wrote:
> Change the device name of the regulator function to the one chosen for
> MODULE_ALIAS. This fixes kernel auto-module loading for the regulator function.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> Hi,
> I don't have the hardware to test, but I think this needs fix.
> We have a similar fix in
> commit ec8da805c43a "mfd: tps6586x: correct device name of the regulator cell".
>
> drivers/mfd/pcf50633-core.c | 2 +-
> drivers/regulator/pcf50633-regulator.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Patch looks fine to me and I can't fine any other instances of the
name.
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/mfd/pcf50633-core.c b/drivers/mfd/pcf50633-core.c
> index 6841d68..41ab5e3 100644
> --- a/drivers/mfd/pcf50633-core.c
> +++ b/drivers/mfd/pcf50633-core.c
> @@ -245,7 +245,7 @@ static int pcf50633_probe(struct i2c_client *client,
> for (i = 0; i < PCF50633_NUM_REGULATORS; i++) {
> struct platform_device *pdev;
>
> - pdev = platform_device_alloc("pcf50633-regltr", i);
> + pdev = platform_device_alloc("pcf50633-regulator", i);
> if (!pdev) {
> dev_err(pcf->dev, "Cannot create regulator %d\n", i);
> continue;
> diff --git a/drivers/regulator/pcf50633-regulator.c b/drivers/regulator/pcf50633-regulator.c
> index d7da1c1..134f90e 100644
> --- a/drivers/regulator/pcf50633-regulator.c
> +++ b/drivers/regulator/pcf50633-regulator.c
> @@ -105,7 +105,7 @@ static int pcf50633_regulator_probe(struct platform_device *pdev)
>
> static struct platform_driver pcf50633_regulator_driver = {
> .driver = {
> - .name = "pcf50633-regltr",
> + .name = "pcf50633-regulator",
> },
> .probe = pcf50633_regulator_probe,
> };
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-12-02 10:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-30 4:21 [RFT][PATCH] mfd: pcf50633: Correct device name for pcf50633 regulator Axel Lin
2013-12-02 10:59 ` Lee Jones [this message]
2013-12-02 17:59 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131202105918.GA31626@lee--X1 \
--to=lee.jones@linaro.org \
--cc=axel.lin@ingics.com \
--cc=balajirrao@openmoko.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox