From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753469Ab3LBLRa (ORCPT ); Mon, 2 Dec 2013 06:17:30 -0500 Received: from mail-ie0-f178.google.com ([209.85.223.178]:40533 "EHLO mail-ie0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753080Ab3LBLR3 (ORCPT ); Mon, 2 Dec 2013 06:17:29 -0500 Date: Mon, 2 Dec 2013 11:17:23 +0000 From: Lee Jones To: Alexander Shiyan Cc: Samuel Ortiz , linux-kernel@vger.kernel.org, Michael Grzeschik , Sascha Hauer , Shawn Guo , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH RESEND] mfd: mc13xxx: Fix null pointer dereference in mc13xxx_common_init Message-ID: <20131202111723.GD31626@lee--X1> References: <1385787337-5296-1-git-send-email-shc_work@mail.ru> <1385805125.304293643@f433.i.mail.ru> <20131202105650.GD29373@lee--X1> <1385982663.209903201@f198.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1385982663.209903201@f198.i.mail.ru> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 02 Dec 2013, Alexander Shiyan wrote: > > > > Понедельник, 2 декабря 2013, 10:56 UTC от Lee Jones : > > On Sat, 30 Nov 2013, Alexander Shiyan wrote: > > > > > > On Sat, Nov 30, 2013 at 08:55:37AM +0400, Alexander Shiyan wrote: > > > > > If this driver being loaded from devicetree, the pdata is NULL. > > > > > This cause kernel Oops when "fsl,mc13xxx-uses-codec" and/or > > > > > "fsl,mc13xxx-uses-touch" properties is specified. > > > > > > > > > > mc13xxx spi0.0: mc13783: rev: 3.3, fin: 0, fab: 0, icid: 2/0 > > > > > Unable to handle kernel NULL pointer dereference at virtual address 00000018 > > > ... > > > > > - if (mc13xxx->flags & MC13XXX_USE_TOUCHSCREEN) > > > > > + if ((mc13xxx->flags & MC13XXX_USE_CODEC) && pdata) > > > > > > > > Why do we check for CODEC if the Touchscreen should be used? > > > > > > Oops, my fault, copy/paste bug. > > > I'll send the corrected version. > > > > No, please don't. > > > > Just provide proper Device Tree support. > > I still have two incomplete MC13XXX DT-related patches. > http://lists.infradead.org/pipermail/linux-arm-kernel/2013-June/175099.html > http://lists.infradead.org/pipermail/linux-arm-kernel/2013-July/182116.html Patches from June and July are no longer pending. They need to be refreshed if you stand any chance of then being accepted. > I'll resume to work on this (and CODEC & TS too). Okay, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog