Re: [PATCH V2] perf Makefile: Correct the message in feature-libnuma checking.

[Arnaldo Carvalho de Melo <acme@ghostprotocols.net>]

Em Sun, Dec 01, 2013 at 09:31:28PM -0500, Peter Hurley escreveu:
> On 12/02/2013 10:26 AM, Dongsheng Yang wrote:
> >The package required for numa is named numactl-devel in Fedora or RHEL,
> >and libnuma-devel in OpenSuSE, and libnuma-dev in Ubuntu. This patch
> >corrects the package name in warning message in feature-libnuma checking.
> 
> Thanks (and thanks for correcting the other lib names).

I'll take this as an:

Acked-by: Peter Hurley <peter@hurleysoftware.com>

Ok?

Please read Documentation/SubmittingPatches, relevant part:

------------------------------------------------------------
13) When to use Acked-by: and Cc:

The Signed-off-by: tag indicates that the signer was involved in the
development of the patch, or that he/she was in the patch's delivery path.

If a person was not directly involved in the preparation or handling of a
patch but wishes to signify and record their approval of it then they can
arrange to have an Acked-by: line added to the patch's changelog.

Acked-by: is often used by the maintainer of the affected code when that
maintainer neither contributed to nor forwarded the patch.

Acked-by: is not as formal as Signed-off-by:.  It is a record that the acker
has at least reviewed the patch and has indicated acceptance.  Hence patch
mergers will sometimes manually convert an acker's "yep, looks good to me"
into an Acked-by:.

Acked-by: does not necessarily indicate acknowledgement of the entire patch.
For example, if a patch affects multiple subsystems and has an Acked-by: from
one subsystem maintainer then this usually indicates acknowledgement of just
the part which affects that maintainer's code.  Judgement should be used here.
When in doubt people should refer to the original discussion in the mailing
list archives.

If a person has had the opportunity to comment on a patch, but has not
provided such comments, you may optionally add a "Cc:" tag to the patch.
This is the only tag which might be added without an explicit action by the
person it names.  This tag documents that potentially interested parties
have been included in the discussion
------------------------------------------------------------
 
Thanks,

- Arnaldo