Re: [alsa-devel] [PATCH 2/3] ASoC: ux500_pcm: Differentiate between pdata and DT initialisation

[Lee Jones <lee.jones@linaro.org>]

On Tue, 03 Dec 2013, Lars-Peter Clausen wrote:

> On 12/03/2013 09:36 AM, Lee Jones wrote:
> >On Mon, 02 Dec 2013, Lars-Peter Clausen wrote:
> >
> >>On 12/02/2013 07:00 PM, Lee Jones wrote:
> >>>If booting with full DT support (i.e. DMA too, the last piece of the
> >>>puzzle), then we don't need to use the compatible request channel call
> >>>back. We also require slightly different flags to inform the core that
> >>>we are booting with DT.
> >>
> >>I don't think you need differentiate between DT and non-DT here.
> >>If the SND_DMAENGINE_PCM_FLAG_COMPAT is set and the
> >>SND_DMAENGINE_PCM_FLAG_NO_DT is not set it will first try to request the
> >>channels from the DT if that fails it will fallback to the compat path. So
> >>all this patch needs to do is remove the SND_DMAENGINE_PCM_FLAG_NO_DT, that
> >>should be it.
> >
> >I have no way of testing that, as we are currently 80% through
> >shutting down platform data altogether. In fact, I think there is only
> >ASoC to be converted. Most of this stuff is going to be ripped out
> >within the next couple of weeks in any case. It will happen as soon as
> >I can find an hour or two to work on it.
> >
> >For that reason I didn't want to disturb the current semantics. I've
> >already found that a bunch of he generic (oh, you can just use the
> >central) functions (for that) don't actually work for us for one
> >reason or another.
> 
> All SND_DMAENGINE_PCM_FLAG_NO_DT does is to skip trying to request
> the channel from the dt. If of_node is NULL this step will be
> skipped anyway. So only setting SND_DMAENGINE_PCM_FLAG_NO_DT if we
> already know that the node is NULL is redundant.

I'll just have to trust you on this and resubmit with the other patch.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog