From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752593Ab3LCKE3 (ORCPT ); Tue, 3 Dec 2013 05:04:29 -0500 Received: from ipmail06.adl2.internode.on.net ([150.101.137.129]:60757 "EHLO ipmail06.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751775Ab3LCKE0 (ORCPT ); Tue, 3 Dec 2013 05:04:26 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvQGANSrnVJ5LHyk/2dsb2JhbABagweDMbBzhU6BGBd0giUBAQUOLBwPFBAIAw4KCSUPBSUDIROIAMEuFxaOEVcHhDMDmBOKTIdIgz0ogS0 Date: Tue, 3 Dec 2013 21:04:21 +1100 From: Dave Chinner To: Vladimir Davydov Cc: hannes@cmpxchg.org, mhocko@suse.cz, dchinner@redhat.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, devel@openvz.org, glommer@openvz.org, Mel Gorman , Rik van Riel Subject: Re: [PATCH v12 06/18] vmscan: rename shrink_slab() args to make it more generic Message-ID: <20131203100421.GR10988@dastard> References: <6fbe648a707331e0716cc7a4fc6366ca83a97f6a.1385974612.git.vdavydov@parallels.com> <20131203093323.GC8803@dastard> <529DA806.5010307@parallels.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <529DA806.5010307@parallels.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 03, 2013 at 01:44:38PM +0400, Vladimir Davydov wrote: > On 12/03/2013 01:33 PM, Dave Chinner wrote: > >> kmemcg reclaim is introduced, we will have to make up phony values for > >> nr_pages_scanned and lru_pages again when doing kmem-only reclaim for a > >> memory cgroup, which is possible if the cgroup has its kmem limit less > >> than the total memory limit. > > I'm missing something here - why would memcg reclaim require > > passing phony values? How are you going to keep slab caches in > > balance with memory pressure generated by the page cache? > > To perform kmem-only reclaim - please see patch 13. When the kmem limit > is less than the user limit, we can reach only the kmem limit. It is no > use trying to reclaim page cache then. Oh dear. What a nasty hack. Dave. -- Dave Chinner david@fromorbit.com