Re: [PATCH v3 36/36] ARM: STi: Add support for the FSM Serial Flash Controller

srinivas kandagatla
2013-12-02T13:32:34Z

On 02/12/13 13:20, Lee Jones wrote:
>>> + /* FSM */
>>> + spifsm: spifsm@fe902000{
>>> + compatible = "st,spi-fsm", "simple-bus";
>> "simple-bus" is redundant here.
>
> Yes I agree, good spot.
>
> I removed it from the Documentation, but missed this one.
>
> If I remove it, can I add your Ack for the remainder of the patch?
Yes,

Acked-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>

You should be aware that arch/arm/boot/dts/stih416-b2105.dts is not in
mainline yet.

Thanks,
srini

>
>>> + reg = <0xfe902000 0x1000>;
>>> + reg-names = "spi-fsm";
>>> + pinctrl-0 = <&pinctrl_fsm>;
>>> +
>>> + st,syscfg = <&syscfg_rear>;
>>> + st,boot-device-reg = <0x958>;
>>> + st,boot-device-spi = <0x1a>;
>>> +
>>> + status = "okay";
>>> + };
>