Re: [PATCH v3 14/36] mtd: st_spi_fsm: Add device-tree binding documentation

Lee Jones
2013-12-03T12:31:40Z

On Tue, 03 Dec 2013, Linus Walleij wrote:

> On Tue, Dec 3, 2013 at 12:31 PM, Lee Jones <lee.jones@linaro.org> wrote:
> > On Tue, 03 Dec 2013, Linus Walleij wrote:
>
> >> So it can be in <linux/mfd/my-sysconfig-regs.h> as
> >> a
> >>
> >> #define MY_SYSCON_V1_BOOT_DEV_REG 0x958
> >> #define MY_SYSCON_V1_BOOT_DEV_SPI 0x1a
> >>
> >> The kernel should know which SoC is in use and
> >> act apropriately right?
> >
> > And this have lots of machine_is() calls everywhere?
>
> No need for Mr. Everywhere to know about the SoC.
>
> There are other ways to achieve this. arch/arm/mach-foo
> always knows which ASIC it is running on, and it can do
> various things:
>
> - Add device tree fragments/overlays (OK high-tech, but
> we're getting to this, inevitably)
>
> - Selectively add AUXDATA, which is absolutely OK if
> we can do autoprobing of hardware IMO.

I prefer our solution TBH.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog