From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754782Ab3LCQld (ORCPT ); Tue, 3 Dec 2013 11:41:33 -0500 Received: from cavan.codon.org.uk ([93.93.128.6]:33576 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754754Ab3LCQl2 (ORCPT ); Tue, 3 Dec 2013 11:41:28 -0500 Date: Tue, 3 Dec 2013 16:41:11 +0000 From: Matthew Garrett To: Hanjun Guo Cc: "Rafael J. Wysocki" , Catalin Marinas , Will Deacon , Russell King - ARM Linux , Daniel Lezcano , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Grant Likely , Olof Johansson , Linus Walleij , Bjorn Helgaas , Rob Herring , Mark Rutland , Jon Masters , patches@linaro.org, linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org, linaro-acpi@lists.linaro.org, Graeme Gregory , Al Stone Subject: Re: [RFC part1 PATCH 1/7] ACPI: Make ACPI core running without PCI on ARM64 Message-ID: <20131203164111.GA13447@srcf.ucam.org> References: <1386088611-2801-1-git-send-email-hanjun.guo@linaro.org> <1386088611-2801-2-git-send-email-hanjun.guo@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1386088611-2801-2-git-send-email-hanjun.guo@linaro.org> User-Agent: Mutt/1.5.20 (2009-06-14) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: mjg59@cavan.codon.org.uk X-SA-Exim-Scanned: No (on cavan.codon.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Given the number of #ifdefs you're adding, wouldn't it make more sense to just add stub functions to include/linux/pci.h? -- Matthew Garrett | mjg59@srcf.ucam.org