From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754774Ab3LCUER (ORCPT ); Tue, 3 Dec 2013 15:04:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:12478 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754164Ab3LCUEO (ORCPT ); Tue, 3 Dec 2013 15:04:14 -0500 Date: Tue, 3 Dec 2013 21:05:07 +0100 From: Oleg Nesterov To: Sameer Nanda Cc: Andrew Morton , David Rientjes , Frederic Weisbecker , Mandeep Singh Baines , "Ma, Xindong" , Michal Hocko , Sergey Dyasly , "Tu, Xiaobing" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] oom_kill: change oom_kill.c to use for_each_thread() Message-ID: <20131203200507.GC19083@redhat.com> References: <20131202152423.GA10878@redhat.com> <20131202152440.GA10900@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/03, Sameer Nanda wrote: > > Reviewed-by: Sameer Nanda Thanks! > > -static bool has_intersects_mems_allowed(struct task_struct *tsk, > > +static bool has_intersects_mems_allowed(struct task_struct *start, > Comment block needs to be fixed up due to variable name change from > tsk to start. thanks again, I'll update the patch. Oleg.