From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755274Ab3LDBv7 (ORCPT ); Tue, 3 Dec 2013 20:51:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49893 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754373Ab3LDBv6 (ORCPT ); Tue, 3 Dec 2013 20:51:58 -0500 Date: Wed, 4 Dec 2013 09:51:27 +0800 From: Baoquan He To: Vivek Goyal Cc: mjg59@srcf.ucam.org, greg@kroah.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, ebiederm@xmission.com, hpa@zytor.com Subject: Re: [PATCH 6/6] kexec: Support for Kexec on panic using new system call Message-ID: <20131204015127.GC3298@localhost.localdomain> References: <1384969851-7251-1-git-send-email-vgoyal@redhat.com> <1384969851-7251-7-git-send-email-vgoyal@redhat.com> <20131128112816.GC4318@dhcp-16-252.nay.redhat.com> <20131202153037.GD18642@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131202153037.GD18642@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/02/13 at 10:30am, Vivek Goyal wrote: > On Thu, Nov 28, 2013 at 07:28:16PM +0800, Baoquan He wrote: > > [..] > > > +int crash_copy_backup_region(struct kimage *image) > > > +{ > > > > Why need this func be called, backup region has been added into crash > > segment by kexec_add_buffer, and then buffer copy is done in > > kimage_load_crash_segment. I think this copy is handled twice. Please > > correct me if I am wrong. > > > > Hi Bao, > > kexec_add_buffer() will copy the backup region but it will happen when > crash kernel is loaded. We want snapshot of backup region at the time > of crash and that's why this second call to copy backup region and it > is executed after the crash. Did we do this before? And will this region be changed after 1st kernel boot > > Thanks > Vivek > > _______________________________________________ > kexec mailing list > kexec@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/kexec