From: "David E. Box" <david.e.box@linux.intel.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: rjw@rjwysocki.net, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCHv2 2/2] ACPI/platform: Add ACPI ID for Intel MBI device
Date: Tue, 3 Dec 2013 18:17:03 -0800 [thread overview]
Message-ID: <20131204021703.GA8282@linux.intel.com> (raw)
In-Reply-To: <20131204013001.GA25037@srcf.ucam.org>
On Wed, Dec 04, 2013 at 01:30:01AM +0000, Matthew Garrett wrote:
> On Tue, Dec 03, 2013 at 03:59:38PM -0800, David E. Box wrote:
> > From: "David E. Box" <david.e.box@linux.intel.com>
> >
> > Adds ACPI ID for Intel IOSF-SB MailBox device found in BayTrail platforms.
>
> Little bit confused here. This is a new driver and only declares
> modaliases for the ACPI IDs - why does it need to be added here?
>
This is per the requirement in Documentation/acpi/enumeration.txt:
"Currently the kernel is not able to automatically determine from which ACPI
device it should make the corresponding platform device so we need to add
the ACPI device explicitly to acpi_platform_device_ids list defined in
drivers/acpi/acpi_platform.c"
Without adding the device here it would not be discovered and probe would not be
called during init.
David Box
> --
> Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2013-12-04 2:18 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 6:05 [PATCH 1/2] New Driver for IOSF-SB MBI access on Intel SOCs David E. Box
2013-11-22 6:05 ` [PATCH 2/2] ACPI / platform: Add ACPI ID for Intel IOSF-SB David E. Box
2013-11-22 18:18 ` [PATCH 1/2] New Driver for IOSF-SB MBI access on Intel SOCs Matthew Garrett
2013-11-24 0:41 ` One Thousand Gnomes
2013-12-03 23:59 ` [PATCHv2 0/2] New driver for Intel IOSF MBI access David E. Box
2013-12-03 23:59 ` [PATCHv2 1/2] New Driver for IOSF-SB MBI access on Intel SOCs David E. Box
2013-12-04 6:44 ` Andi Kleen
2013-12-03 23:59 ` [PATCHv2 2/2] ACPI/platform: Add ACPI ID for Intel MBI device David E. Box
2013-12-04 1:30 ` Matthew Garrett
2013-12-04 2:17 ` David E. Box [this message]
2013-12-04 2:21 ` Matthew Garrett
2013-12-04 2:44 ` David E. Box
2013-12-04 2:54 ` Matthew Garrett
2013-12-04 21:34 ` Rafael J. Wysocki
2013-12-05 20:01 ` [PATCH] X86 platform: New IOSF-SB MBI driver for Intel SOCs David E. Box
2013-12-05 22:32 ` Rafael J. Wysocki
2013-12-06 20:59 ` [PATCH] X86 platform: New BayTrail IOSF-SB MBI driver David E. Box
2013-12-07 1:29 ` Rafael J. Wysocki
2013-12-10 1:11 ` David E. Box
2013-12-19 22:37 ` [PATCH v5][RESEND] " David E. Box
2013-12-20 1:59 ` Rafael J. Wysocki
2013-12-20 7:01 ` David E. Box
2013-12-30 18:12 ` [PATCH v6] " David E. Box
2014-01-07 18:03 ` [PATCH v6][RESEND] platform: x86: " David E. Box
2014-01-07 18:15 ` Randy Dunlap
2014-01-07 18:48 ` David E. Box
2014-01-07 19:30 ` Randy Dunlap
2014-01-07 20:46 ` Rafael J. Wysocki
2014-01-07 21:43 ` David E. Box
2014-01-08 0:11 ` Rafael J. Wysocki
2014-01-08 0:00 ` H. Peter Anvin
2014-01-08 5:27 ` David E. Box
2014-01-08 13:47 ` Rafael J. Wysocki
2014-01-08 21:27 ` [PATCH v7] arch: x86: New MailBox support driver for Intel SOC's David E. Box
2014-01-10 22:10 ` [tip:x86/platform] " tip-bot for David E. Box
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131204021703.GA8282@linux.intel.com \
--to=david.e.box@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).