From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753651Ab3LDHDk (ORCPT ); Wed, 4 Dec 2013 02:03:40 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:57802 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751614Ab3LDHDj (ORCPT ); Wed, 4 Dec 2013 02:03:39 -0500 Date: Tue, 3 Dec 2013 23:04:42 -0800 From: Greg Kroah-Hartman To: Adrien =?iso-8859-1?Q?Verg=E9?= Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Russell King , Ben Dooks , Will Deacon , Dietmar Eggemann , Andrew Morton , "zhangwei(Jovi)" , Randy Dunlap Subject: Re: [PATCH 0/3] ARM Coresight: Enhance ETM tracing control Message-ID: <20131204070442.GA31665@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 03, 2013 at 11:39:21PM -0500, Adrien Vergé wrote: > Usage of ETM tracing facility is currently very limited: user can > only start/stop tracing. This set of patches enables management of > address combinations and PIDs that trigger tracing. > > ETM management was done via sysfs entries (trace_info, > trace_running...), this code adds trace_addrrange and trace_pid to > let the user read/write custom values. I have lots to say about this from a sysfs point of view, but first, why is it in sysfs at all? Shouldn't all of this be in debugfs? greg k-h