From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: Aldo Iljazi <mail@aldo.io>,
Samuel Thibault <samuel.thibault@ens-lyon.org>,
w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH] Staging: speakup: synth.c: removed a space
Date: Wed, 4 Dec 2013 11:21:37 +0300 [thread overview]
Message-ID: <20131204082137.GR5443@mwanda> (raw)
In-Reply-To: <1386143115.30493.48.camel@joe-AO722>
You and I generally agree on style preferences... I think the warning
should be limited to grep " ;$".
I did a grep on the kernel for ' ;' and found 8000 results. 6000 of
them are caught by my semicolon before the newline rule. The remaining
2000 are assembly, macros, and crappy for loops.
regards,
dan carpenter
next prev parent reply other threads:[~2013-12-04 8:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 20:08 [PATCH] Staging: speakup: synth.c: removed a space Aldo Iljazi
2013-12-03 22:17 ` Samuel Thibault
2013-12-04 4:35 ` Aldo Iljazi
2013-12-04 7:38 ` Dan Carpenter
2013-12-04 7:45 ` Joe Perches
2013-12-04 8:21 ` Dan Carpenter [this message]
2013-12-04 13:47 ` [PATCH -next] checkpatch: Warn only on "space before semicolon" at end of line Joe Perches
2013-12-05 7:41 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131204082137.GR5443@mwanda \
--to=dan.carpenter@oracle.com \
--cc=apw@canonical.com \
--cc=chris@the-brannons.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@aldo.io \
--cc=samuel.thibault@ens-lyon.org \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox