From: Ingo Molnar <mingo@kernel.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Oleg Nesterov <oleg@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Olivier Langlois <olivier@olivierlanglois.net>,
Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: Re: [GIT PULL v2] dynticks updates for 3.14
Date: Wed, 4 Dec 2013 10:11:43 +0100 [thread overview]
Message-ID: <20131204091143.GA32224@gmail.com> (raw)
In-Reply-To: <1386081506-24358-1-git-send-email-fweisbec@gmail.com>
* Frederic Weisbecker <fweisbec@gmail.com> wrote:
> Ingo,
>
> Please pull the timers/core-v2 branch that can be found at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
> timers/core-v2
>
> It's a rebase of the previous pull request against 3.13-rc2 which addresses
> your reviews:
>
> * Fix build error with tick_check_nohz() off case
>
> * Refine changelog of "posix-timers: Fix full dynticks CPUs kick on timer rescheduling"
> to make it clearer that it's a bug fix and not just an optimization.
> Also add more overall details in the changelog about the description of the issue.
>
> * Rename tick_check_nohz() and tick_check_oneshot_broadcast() to extend with *_this_cpu()
> suffix. Note that I left functions that use *_idle_* based naming as is because idle
> itself is a per cpu notion already. Now I can still extend these functions as well
> in a delta if you want, although IMHO I fear that would uglify the code more than helping.
>
> ---
> Here is a summary of the overall changes against tip:timers/core :
>
> * Optimizations and cleanups on the use of per CPU APIs to improve code readability,
> performance and debuggability in the nohz subsystem;
>
> * Rename some functions to extend with *_this_cpu() suffix for clarity
>
> * Refine the naming of some context tracking subsystem state accessors
>
> * Optimize posix cpu timer by sparing stub workqueue queue with full dynticks off case
>
> * Trivial spelling fix by Paul Gortmaker
>
> * Fix a bug where posix cpu timers requeued due to interval got ignored on full
> dynticks CPUs (not a regression though as it only impacts full dynticks and the
> bug is there since we merged full dynticks).
>
>
> Let me know if you find any issue.
>
> Thanks,
> Frederic
> ---
>
> Frederic Weisbecker (5):
> nohz: Convert a few places to use local per cpu accesses
> context_tracking: Wrap static key check into more intuitive function name
> context_tracking: Rename context_tracking_active() to context_tracking_cpu_is_enabled()
> posix-timers: Spare workqueue if there is no full dynticks CPU to kick
> posix-timers: Fix full dynticks CPUs kick on timer rescheduling
>
> Paul Gortmaker (1):
> trivial: fix spelling in CONTEXT_TRACKING_FORCE help text
>
>
> include/linux/context_tracking.h | 10 ++++-----
> include/linux/context_tracking_state.h | 11 +++++++---
> include/linux/tick.h | 8 +++----
> include/linux/vtime.h | 4 ++--
> init/Kconfig | 2 +-
> kernel/context_tracking.c | 8 +++----
> kernel/posix-cpu-timers.c | 21 ++++++++----------
> kernel/softirq.c | 4 +---
> kernel/time/tick-broadcast.c | 6 +++---
> kernel/time/tick-internal.h | 4 ++--
> kernel/time/tick-sched.c | 39 ++++++++++++++--------------------
> 11 files changed, 55 insertions(+), 62 deletions(-)
Pulled into tip:timers/core, thanks a lot Frederic!
Ingo
prev parent reply other threads:[~2013-12-04 9:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 14:38 [GIT PULL v2] dynticks updates for 3.14 Frederic Weisbecker
2013-12-03 14:38 ` [PATCH 1/6] nohz: Convert a few places to use local per cpu accesses Frederic Weisbecker
2013-12-03 14:38 ` [PATCH 2/6] trivial: fix spelling in CONTEXT_TRACKING_FORCE help text Frederic Weisbecker
2013-12-03 14:38 ` [PATCH 3/6] context_tracking: Wrap static key check into more intuitive function name Frederic Weisbecker
2013-12-03 14:38 ` [PATCH 4/6] context_tracking: Rename context_tracking_active() to context_tracking_cpu_is_enabled() Frederic Weisbecker
2013-12-03 14:38 ` [PATCH 5/6] posix-timers: Spare workqueue if there is no full dynticks CPU to kick Frederic Weisbecker
2013-12-03 14:38 ` [PATCH 6/6] posix-timers: Fix full dynticks CPUs kick on timer rescheduling Frederic Weisbecker
2013-12-04 9:11 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131204091143.GA32224@gmail.com \
--to=mingo@kernel.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=olivier@olivierlanglois.net \
--cc=paul.gortmaker@windriver.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox