From: Thierry Reding <thierry.reding@gmail.com>
To: Stefan Agner <stefan@agner.ch>
Cc: swarren@wwwdotorg.org, dev@lynxeye.de, lee.jones@linaro.org,
lgirdwood@gmail.com, broonie@kernel.org,
kai.poggensee@avionic-design.de, sameo@linux.intel.com,
linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] mfd: tps6586x: add version detection
Date: Wed, 4 Dec 2013 10:24:30 +0100 [thread overview]
Message-ID: <20131204092429.GM19943@ulmo.nvidia.com> (raw)
In-Reply-To: <77384d24810d9a22fc04cad6f7468f54a9cbaafe.1386100296.git.stefan@agner.ch>
[-- Attachment #1: Type: text/plain, Size: 800 bytes --]
On Tue, Dec 03, 2013 at 08:57:27PM +0100, Stefan Agner wrote:
> Use the VERSIONCRC to determine the exact device version. According to
> the datasheet this register can be used as device identifier. The
> identification is needed since some tps6586x regulators use a different
> voltage table.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> Since the struct tps6586x is inside the c file, I could not easily
> move the tps6586x_get_version function as inline to the header file.
>
> Changes since v2:
> - Avoid moving devm_kzalloc
> ---
> drivers/mfd/tps6586x.c | 43 ++++++++++++++++++++++++++++++++++++++-----
> include/linux/mfd/tps6586x.h | 7 +++++++
> 2 files changed, 45 insertions(+), 5 deletions(-)
Reviewed-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-12-04 9:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 19:57 [PATCH v3 0/3] regulator: tps6586x: add version detection and voltage tables Stefan Agner
2013-12-03 19:57 ` [PATCH v3 1/3] mfd: tps6586x: add version detection Stefan Agner
2013-12-04 9:24 ` Thierry Reding [this message]
2013-12-03 19:57 ` [PATCH v3 2/3] regulator: tps6586x: add and use correct voltage table Stefan Agner
2013-12-04 9:31 ` Thierry Reding
2013-12-03 19:57 ` [PATCH v3 3/3] ARM: tegra: correct Colibri T20 regulator settings Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131204092429.GM19943@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=broonie@kernel.org \
--cc=dev@lynxeye.de \
--cc=kai.poggensee@avionic-design.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=stefan@agner.ch \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox