Re: [PATCH v3 1/3] mfd: tps6586x: add version detection

Thierry Reding
2013-12-04T09:25:33Z

[-- Attachment #1: Type: text/plain, Size: 800 bytes --]

On Tue, Dec 03, 2013 at 08:57:27PM +0100, Stefan Agner wrote:
> Use the VERSIONCRC to determine the exact device version. According to
> the datasheet this register can be used as device identifier. The
> identification is needed since some tps6586x regulators use a different
> voltage table.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> Since the struct tps6586x is inside the c file, I could not easily
> move the tps6586x_get_version function as inline to the header file.
>
> Changes since v2:
> - Avoid moving devm_kzalloc
> ---
> drivers/mfd/tps6586x.c | 43 ++++++++++++++++++++++++++++++++++++++-----
> include/linux/mfd/tps6586x.h | 7 +++++++
> 2 files changed, 45 insertions(+), 5 deletions(-)

Reviewed-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]