From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755585Ab3LDLsb (ORCPT ); Wed, 4 Dec 2013 06:48:31 -0500 Received: from mail-yh0-f50.google.com ([209.85.213.50]:60280 "EHLO mail-yh0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754956Ab3LDLsa (ORCPT ); Wed, 4 Dec 2013 06:48:30 -0500 Date: Wed, 4 Dec 2013 11:48:22 +0000 From: Lee Jones To: Stefan Agner Cc: swarren@wwwdotorg.org, thierry.reding@gmail.com, dev@lynxeye.de, lgirdwood@gmail.com, broonie@kernel.org, kai.poggensee@avionic-design.de, sameo@linux.intel.com, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/3] mfd: tps6586x: add version detection Message-ID: <20131204114822.GD907@lee--X1> References: <77384d24810d9a22fc04cad6f7468f54a9cbaafe.1386108712.git.stefan@agner.ch> <20131204081021.GB7469@lee--X1> <20131204100728.GA907@lee--X1> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 04 Dec 2013, Stefan Agner wrote: > Am 2013-12-04 11:07, schrieb Lee Jones: > > On Wed, 04 Dec 2013, Stefan Agner wrote: > > > >> Am 2013-12-04 09:10, schrieb Lee Jones: > >> >> +int tps6586x_get_version(struct device *dev) > >> >> +{ > >> >> + struct tps6586x *tps6586x = dev_get_drvdata(dev); > >> >> + > >> >> + return tps6586x->version; > >> >> +} > >> >> +EXPORT_SYMBOL_GPL(tps6586x_get_version); > >> > > >> > I thought Mark suggested that this routine was converted to a 'static > >> > inline' and moved into the header? Did you not think this was a good > >> > idea? > >> As I pointed out in the comment above, the struct tps6586x is in the C > >> file, so I would need to move that too. That's why I did not made that > >> change in the end. What do you think, should I still move (and move the > >> struct too?) > > > > Why would the struct have to be moved if the function is inline? > > True, the inline I could have done without moving the struct and the > function. Would you like me to create another revision doing this? > > But moving the function needs moving of the struct tps6586x > declaration... > > [Sorry, this time with answer all] Do you know what, it's really not that important. Patch applied. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog