From: Dan Carpenter <dan.carpenter@oracle.com>
To: Gary Rookard <garyrookard@gmail.com>
Cc: gregkh@linuxfoundatio.org, devel@driverdev.osuosl.org,
lisa@xenapiadmin.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: bcm: DDRInit: Fixed non_standard kernel style.
Date: Wed, 4 Dec 2013 15:56:47 +0300 [thread overview]
Message-ID: <20131204125646.GQ28413@mwanda> (raw)
In-Reply-To: <1386150789-7431-1-git-send-email-garyrookard@gmail.com>
On Wed, Dec 04, 2013 at 04:53:09AM -0500, Gary Rookard wrote:
> Fixed non_standard kernel style.
>
You're doing too many things at once, it needs to be broken into
a patch series which do one type of change at a time.
The changelog is useless.
> Signed off by: Gary Alan Rookard <garyrookard@gmail.com>
> ---
> drivers/staging/bcm/DDRInit.c | 2081 +++++++++++++++++++----------------------
> 1 file changed, 977 insertions(+), 1104 deletions(-)
>
> diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c
> index 9f7e30f..2fc3ba9 100644
> --- a/drivers/staging/bcm/DDRInit.c
> +++ b/drivers/staging/bcm/DDRInit.c
> @@ -1,977 +1,876 @@
> -#include "headers.h"
> -
> +/* File: DDRInit.c */
This isn't useful.
> + {0x0F000840, 0x0FFF1B00}, /* Changed Source for X-bar and MIPS Clock to APLL */
> + {0xF0000870, 0x00000002},
> + {0x0F00A044, 0x1FFFFFFF},
> + {0x0F00A040, 0x1F000000},
One of these is not like the others. You have introduced a bug with
0xF0000870 vs 0x0F000870.
regards,
dan carpenter
prev parent reply other threads:[~2013-12-04 12:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 9:53 [PATCH] Staging: bcm: DDRInit: Fixed non_standard kernel style Gary Rookard
2013-12-04 12:56 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131204125646.GQ28413@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=garyrookard@gmail.com \
--cc=gregkh@linuxfoundatio.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lisa@xenapiadmin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox